Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Rpc support #1052

Merged
merged 37 commits into from
May 23, 2024
Merged

ENH: Rpc support #1052

merged 37 commits into from
May 23, 2024

Conversation

nstelter-slac
Copy link
Collaborator

@nstelter-slac nstelter-slac commented Nov 28, 2023 •
edited
Loading

Add support for RPC using p4p extension (https://mdavidsaver.github.io/p4p/rpc.html).

More context here: #1035

Could expand to have RPC address editor in designer

@nstelter-slac
Copy link
Collaborator Author

https://mdavidsaver.github.io/p4p/client.html#p4p.client.thread.Context.rpc

@YektaY YektaY marked this pull request as ready for review December 6, 2023 21:28
@nstelter-slac nstelter-slac linked an issue Dec 6, 2023 that may be closed by this pull request
Add RPC Support #1035
Closed
@YektaY YektaY changed the title Rpc support ENH: Rpc support Apr 30, 2024
nstelter-slac added 21 commits May 2, 2024 13:04
@nstelter-slac
WIP: Add simple rpc server
e7af7b5
@nstelter-slac
WIP: add draft for simple rpc example
21b6d76
@nstelter-slac
WIP: Add simple rpc client example
a99cb9a
@nstelter-slac
WIP: Style updates to rpc example and example-server
4c85f40
@nstelter-slac
WIP: RPC support in working state
d9956bb
@nstelter-slac
ENH: Add RPC support
b12a55b
@nstelter-slac
STY: Cleanup rpc example client/server and some p4p imports
6609f51
@nstelter-slac
TST: Add tst for parsing RPC channel info
ad40187
@nstelter-slac
TST: switch to checking if rpc address to use regex and add test for …
add82f0 
…check
@nstelter-slac
TST: Add more tests for RPC support
f399ce2 
Tests for checking if RPC request and for constructing p4p Value obj.

Also now don't parse for RPC unless know its a valid request,
and now able to emit discon signal when polling.
@nstelter-slac
ENH: Add support for string args in RPC requests
4512d7d
@nstelter-slac
BUG: Have rpc requesting polling only launch 1 thread
96bec84 
And have the thread be killed if the pydm window closes.
Also now correctly have pollrate value as float.
@nstelter-slac
BUG: Make so rpc-polling only uses a single background thread
9c7c59d
@nstelter-slac
DOC: Add RPC info to docs
3b600dd
@nstelter-slac
STY: minor update to RPC comments
e669001
@nstelter-slac
BUG: Make RPC polling thread a daemon so closes when PyDM does
4c39ebc
@nstelter-slac
BUG: Fix issue where RPC widgets have slow timeout when can't connect
5c2ad8d 
Fixes issue where screen with many RPC widgets will stall
when loading if can't connect to addresses (such as when  not connected
to the network).
@nstelter-slac
STY: Add comment on why using daemon threads for RPC polling
4b6ceac
@nstelter-slac
STY: Add comments related to RPC server and client examples
c50c1aa
@nstelter-slac
DOC: Exapand docs for RPC support
1515213
@nstelter-slac
DOC: remove reference to only working with PyDMLabel
145227b 
Since should work with any widget that expects back a value to display
(also works with byte-indicator widget)
@nstelter-slac
Copy link
Collaborator Author

nstelter-slac commented May 9, 2024 •
edited
Loading

to test real PV,
have setup the prod-on-dev env, then:

cd examples/rpc
pydm rpc_labels.ui
->open in designer and modify one of the labels to have address:
pva://KLYS:LI12:11:ATTN_CUR&

can also try it with polling:
pva://KLYS:LI12:11:ATTN_CUR&pydm_pollrate=3.0

jbellister-slac
jbellister-slac reviewed May 22, 2024
View reviewed changes
Copy link
Collaborator

@jbellister-slac jbellister-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks! Examples well-explained and work fine, connecting to live data works fine, tests look good.

pydm/data_plugins/epics_plugins/p4p_plugin_component.py Show resolved Hide resolved
YektaY
YektaY reviewed May 22, 2024
View reviewed changes
Copy link
Collaborator

@YektaY YektaY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and worked for me

pydm/data_plugins/epics_plugins/p4p_plugin_component.py Outdated Show resolved Hide resolved
@jbellister-slac jbellister-slac merged commit 9166585 into slaclab:master May 23, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YektaY YektaY YektaY left review comments

@jbellister-slac jbellister-slac jbellister-slac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add RPC Support
3 participants
@nstelter-slac @YektaY @jbellister-slac