Skip to content

Commit

Permalink
MNT: make gh actions install python dependencies using pip, so correc…
Browse files Browse the repository at this point in the history
…t version is installed

For gh actions setup we were passing pip package lists for conda to
install, but this causes us to install old p4p package which only
supports python <=3.10. So need newer p4p from pip to run with newer
python.
  • Loading branch information
nstelter-slac committed Dec 19, 2024
1 parent 00ad39d commit 138bc2f
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,10 @@ jobs:
- name: Install python packages
shell: bash -el {0}
run: |
python -m pip install --upgrade pip
python -m pip install pyqt${{ matrix.pyqt-version }} -r requirements.txt -r dev-requirements.txt
if [ "$RUNNER_OS" == "Windows" ]; then
mamba install pyqt=${{ matrix.pyqt-version }}
mamba install --file requirements.txt --file windows-dev-requirements.txt
else
mamba install pyqt=${{ matrix.pyqt-version }} $(cat requirements.txt dev-requirements.txt)
python -m pip install -r windows-dev-requirements.txt
fi
- name: Install packages for testing a pyqt app on linux
shell: bash -el {0}
Expand Down

0 comments on commit 138bc2f

Please sign in to comment.