slack-19.0
: support consul topo stale reads
#559
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows Vitess components to use stale reads from consul. This is enabled with the flag
--topo_allow_stale_reads
, which is defaultfalse
and should be considered experimental*api.QueryOptions
:This flag allow us to distribute topo
.Get(...)
and.List(...)
load to consul replicas. Also it limits the impact of electionsIt may be safe in use cases like
txthrottler
if stale reads have no impact to any othervttablet
operations. It may be safe to use invtorc
alsoRelated Issue(s)
Checklist
Deployment Notes