Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of PR #12992 #505

Closed
wants to merge 3 commits into from
Closed

Backport of PR #12992 #505

wants to merge 3 commits into from

Conversation

maksimov
Copy link
Collaborator

@maksimov maksimov commented Sep 9, 2024

Description

This is a backport of PR vitessio#12992 which failed to get backported to v15 back in the day, so now we have to make our own patch.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

…donly and replica tablets during a resharding event (vitessio#12992)

* use switcher struct when switching shard reads during a reshard event

Signed-off-by: austenLacy <[email protected]>

* Create failing test for bug reported in vitessio#12992, where a TrafficSwitch dry run for reads during resharding tries to actually switch reads and fails

Signed-off-by: Rohit Nayak <[email protected]>

---------

Signed-off-by: austenLacy <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Co-authored-by: Rohit Nayak <[email protected]>
@maksimov maksimov requested a review from a team as a code owner September 9, 2024 22:32
Copy link

salesforce-cla bot commented Sep 9, 2024

Thanks for the contribution! Before we can merge this, we need @austenLacy to sign the Salesforce Inc. Contributor License Agreement.

@github-actions github-actions bot added this to the v15.0.5 milestone Sep 9, 2024
@maksimov maksimov marked this pull request as draft September 9, 2024 22:34
@maksimov maksimov marked this pull request as ready for review September 9, 2024 23:16
@maksimov
Copy link
Collaborator Author

See #508

@maksimov maksimov closed this Sep 11, 2024
@maksimov maksimov deleted the pr-12992-slack-15.0 branch September 11, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants