Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] VReplication: Make Source Tablet Selection More Robust (#13582) #495

Closed
wants to merge 6 commits into from

Conversation

makinje16
Copy link
Member

Description

This PR backports #13582 in order to fix the NOT_FOUND errors we've seen on the CDC project during tablet failure on the streaming host.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@makinje16 makinje16 requested a review from a team as a code owner August 21, 2024 15:13
Copy link

Thanks for the contribution! Before we can merge this, we need @mattlord to sign the Salesforce Inc. Contributor License Agreement.

@github-actions github-actions bot added this to the v15.0.5 milestone Aug 21, 2024
mattlord and others added 5 commits August 28, 2024 10:56
…492)

* WIP

Signed-off-by: Tim Vaillancourt <[email protected]>

* update all flags

Signed-off-by: Tim Vaillancourt <[email protected]>

* update e2e flag test

Signed-off-by: Tim Vaillancourt <[email protected]>

* 2 missing flags

Signed-off-by: Tim Vaillancourt <[email protected]>

* rename Type()

Signed-off-by: Tim Vaillancourt <[email protected]>

* empty commit to test ci

Signed-off-by: Tim Vaillancourt <[email protected]>

* fakesqldb: Guard query log usage with lock (vitessio#12813)

* fakesqldb: Guard query log usage with lock

This lock is used around adding to the query log, but it means we also
need to use the lock when reading from it or when resetting it.

Signed-off-by: Dirkjan Bussink <[email protected]>

* grpcvtctldserver: Fix alias for loop reuse

Signed-off-by: Dirkjan Bussink <[email protected]>

* unit_race: Increase runtime

We've been adding a lot of tests for the evalengine and we're bumping up
to the timeout.

Signed-off-by: Dirkjan Bussink <[email protected]>

---------

Signed-off-by: Dirkjan Bussink <[email protected]>

* remove t.Parallel() like upstream did

Signed-off-by: Tim Vaillancourt <[email protected]>

---------

Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
Co-authored-by: Dirkjan Bussink <[email protected]>
* `txthrottler`: move `ThrottlerInterface` to `go/vt/throttler`, use `slices` pkg, add stats (vitessio#16248)

Signed-off-by: Tim Vaillancourt <[email protected]>

* revert to `reflect`

Signed-off-by: Tim Vaillancourt <[email protected]>

* Support passing filters to `discovery.NewHealthCheck(...)`

Signed-off-by: Tim Vaillancourt <[email protected]>

* Update go/vt/vttablet/tabletserver/txthrottler/tx_throttler.go

Co-authored-by: Matt Lord <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>

* Address some PR suggestions

Signed-off-by: Tim Vaillancourt <[email protected]>

* PR ctx suggestion

Signed-off-by: Tim Vaillancourt <[email protected]>

* fix test

Signed-off-by: Tim Vaillancourt <[email protected]>

* simplify updateHealthCheckCells signature

Signed-off-by: Tim Vaillancourt <[email protected]>

* Fix race in `replicationLagModule` of `go/vt/throttle`

Signed-off-by: Tim Vaillancourt <[email protected]>

---------

Signed-off-by: Tim Vaillancourt <[email protected]>
Co-authored-by: Matt Lord <[email protected]>
@makinje16 makinje16 closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants