slack-15.0
: support v17+ --queryserver-config-*
duration values
#492
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for v19-style timeout values to make the rollout of v19 easier. Feature flagging this by Vitess version and chef at the same time is too complicated. TL;DR: v17+ expects real time durations, not a number
This change in flag style is explained in these v17 changelog notes
The new
DurationOrSecondsFloatFlag
stores a timeout value in the samefloat64
format but supports parsing string durations (the v19 behaviour) AND floats (the v15 behaviour)Finally, vitessio#12813 was cherry-picked to resolve some CI flakiness preventing this PR from passing CI
Related Issue(s)
Potential CI flake fix: vitessio#12813
Checklist
Deployment Notes