Slack vitess r14.0.5 dsdefense throttle only if lag #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* make column resolution closer to mysql Signed-off-by: Andres Taylor <[email protected]> * Fix bad merge conflict fix Signed-off-by: Tim Vaillancourt <[email protected]> * Possible horizon_planning.go fix Signed-off-by: Tim Vaillancourt <[email protected]> * Fix aggr_cases.json plan Signed-off-by: Tim Vaillancourt <[email protected]> * Fix group by order Signed-off-by: Tim Vaillancourt <[email protected]> * Remove 'TablesUsed', not in v14 Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Tim Vaillancourt <[email protected]> Co-authored-by: Andres Taylor <[email protected]>
Signed-off-by: Eduardo J. Ortega U <[email protected]>
timvaillancourt
approved these changes
Dec 7, 2023
|
@ejortegau I had a thought, does this overlap with the replication lag cache from |
|
This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:
If no action is taken within 7 days, this PR will be closed. |
|
This PR was closed because it has been stale for 7 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an additional condition to be checked before the Transaction Throttler throttles a request. The condition in question is that the max, most recently seen lag in the shard in the replicas being watched, must be above the configured target replication lag. If that's not the case, throttling does not take place.
This addresses the issue mentioned here.