slack-vitess-r14.0.5: allow conn overrides in consul topo
#111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Vaillancourt <[email protected]>
…slack-vitess-r14.0.5
rvrangel
approved these changes
Aug 1, 2023
ejortegau
approved these changes
Aug 7, 2023
…slack-vitess-r14.0.5
timvaillancourt
deleted the
consul-topo-transport-flags-slack-vitess-r14.0.5
branch
maksimov
added a commit
that referenced
this pull request
Aug 10, 2023
* Cleanup usage of go.rice in favor of go:embed (vitessio#10956) * Cleanup usage of go.rice in favor of go:embed The usage of go.rice predates the availability of go:embed, but we should switch to using go:embed instead to ship specific assets like config files that we need. go.rice is also incompatible with Go 1.19 and while it might see a fix in the future, it seems better to go with the recommended Go approach that is available these days. Signed-off-by: Dirkjan Bussink <[email protected]> * Move vtctld to also use `go embed` instead of go.rice Signed-off-by: Dirkjan Bussink <[email protected]> * Remove last rice-box related comments Signed-off-by: Dirkjan Bussink <[email protected]> * Remove config moving This right now breaks building the actual tests since the tests might also end up loading the regular code which has a `go embed` and refers to the package with the config embeds. This doesn't mean that the config isn't properly included in the binaries. Also with using `go embed` we have a build time dependency on the files and we always know the latest is included, so we don't have the issue of potentially outdated files either. All in all, it seems simplest to remove this logic and trust that Go itself works as advertised. Signed-off-by: Dirkjan Bussink <[email protected]> * fix vtrootbin Signed-off-by: 'Stanislav Maksimov' <[email protected]> * update the build to 1.19.10 Signed-off-by: 'Stanislav Maksimov' <[email protected]> * update the workflows to 1.19.10 Signed-off-by: 'Stanislav Maksimov' <[email protected]> * update the docker image to 1.19.10 Signed-off-by: 'Stanislav Maksimov' <[email protected]> * update the bootstrap version to get docker to go 1.20.5 Signed-off-by: 'Stanislav Maksimov' <[email protected]> * use 1.18.7 for static checks Signed-off-by: 'Stanislav Maksimov' <[email protected]> * lower the build version requirement to allow static checks to pass Signed-off-by: 'Stanislav Maksimov' <[email protected]> * experiment with using old and new Go for a single workflow Signed-off-by: 'Stanislav Maksimov' <[email protected]> * use old and new Go for a upgrade/downgrade workflows Signed-off-by: 'Stanislav Maksimov' <[email protected]> * set -buildvcs=false Signed-off-by: 'Stanislav Maksimov' <[email protected]> * address build errors Signed-off-by: 'Stanislav Maksimov' <[email protected]> * Revert "fix parameter name (#93)" (#100) This reverts commit 76159fd. * apply patch 12178 to v14 (#102) Signed-off-by: Priya Bibra <[email protected]> Signed-off-by: 'Priya Bibra' <[email protected]> * more workflows to use self-hosted runner * even more workflows to use self-hosted runner * partially switch upgrade-downgrade to self-hosted runner * Ejortegau/larger runners (#115) * Empty commit to trigger CI Signed-off-by: Eduardo J. Ortega U <[email protected]> * `slack-vitess-r14.0.5-dsdefense`: use larger runner Signed-off-by: Tim Vaillancourt <[email protected]> * Use runner group instead Signed-off-by: Tim Vaillancourt <[email protected]> * Rename group Signed-off-by: Tim Vaillancourt <[email protected]> * Move more jobs to runner group Signed-off-by: Tim Vaillancourt <[email protected]> * use vitess-ubuntu20 runner group Signed-off-by: Tim Vaillancourt <[email protected]> * Rever change of runner type for e2e ERS PRS new features heavy test Signed-off-by: Eduardo J. Ortega U <[email protected]> --------- Signed-off-by: Eduardo J. Ortega U <[email protected]> Signed-off-by: Tim Vaillancourt <[email protected]> Co-authored-by: Tim Vaillancourt <[email protected]> * Revert change of runner type for shardedrecovery_stress_verticalsplit_heavy. (#116) We do this because the test is taking a lot longer & failing in some cases with the larger runner. Signed-off-by: Eduardo J. Ortega U <[email protected]> * `slack-vitess-r14.0.5`: use dedicated larger runner (#113) * `slack-vitess-r14.0.5`: use dedicated larger runner Signed-off-by: Tim Vaillancourt <[email protected]> * fix fileNameFromPosition Signed-off-by: Tim Vaillancourt <[email protected]> * empty commit Signed-off-by: Tim Vaillancourt <[email protected]> * empty commit Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]> * `slack-vitess-r14.0.5`: allow conn overrides in consul topo (#111) * `slack-vitess-r14.0.5`: allow conn overrides in consul topo Signed-off-by: Tim Vaillancourt <[email protected]> * fix e2e test Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Dirkjan Bussink <[email protected]> Signed-off-by: 'Stanislav Maksimov' <[email protected]> Signed-off-by: Priya Bibra <[email protected]> Signed-off-by: 'Priya Bibra' <[email protected]> Signed-off-by: Eduardo J. Ortega U <[email protected]> Signed-off-by: Tim Vaillancourt <[email protected]> Co-authored-by: Dirkjan Bussink <[email protected]> Co-authored-by: Roderick Yao <[email protected]> Co-authored-by: pbibra <[email protected]> Co-authored-by: Eduardo J. Ortega U <[email protected]> Co-authored-by: Tim Vaillancourt <[email protected]>
maksimov
added a commit
that referenced
this pull request
Sep 13, 2023
* Cleanup usage of go.rice in favor of go:embed (vitessio#10956) * Cleanup usage of go.rice in favor of go:embed The usage of go.rice predates the availability of go:embed, but we should switch to using go:embed instead to ship specific assets like config files that we need. go.rice is also incompatible with Go 1.19 and while it might see a fix in the future, it seems better to go with the recommended Go approach that is available these days. Signed-off-by: Dirkjan Bussink <[email protected]> * Move vtctld to also use `go embed` instead of go.rice Signed-off-by: Dirkjan Bussink <[email protected]> * Remove last rice-box related comments Signed-off-by: Dirkjan Bussink <[email protected]> * Remove config moving This right now breaks building the actual tests since the tests might also end up loading the regular code which has a `go embed` and refers to the package with the config embeds. This doesn't mean that the config isn't properly included in the binaries. Also with using `go embed` we have a build time dependency on the files and we always know the latest is included, so we don't have the issue of potentially outdated files either. All in all, it seems simplest to remove this logic and trust that Go itself works as advertised. Signed-off-by: Dirkjan Bussink <[email protected]> * fix vtrootbin Signed-off-by: 'Stanislav Maksimov' <[email protected]> * update the build to 1.19.10 Signed-off-by: 'Stanislav Maksimov' <[email protected]> * update the workflows to 1.19.10 Signed-off-by: 'Stanislav Maksimov' <[email protected]> * update the docker image to 1.19.10 Signed-off-by: 'Stanislav Maksimov' <[email protected]> * update the bootstrap version to get docker to go 1.20.5 Signed-off-by: 'Stanislav Maksimov' <[email protected]> * use 1.18.7 for static checks Signed-off-by: 'Stanislav Maksimov' <[email protected]> * lower the build version requirement to allow static checks to pass Signed-off-by: 'Stanislav Maksimov' <[email protected]> * experiment with using old and new Go for a single workflow Signed-off-by: 'Stanislav Maksimov' <[email protected]> * use old and new Go for a upgrade/downgrade workflows Signed-off-by: 'Stanislav Maksimov' <[email protected]> * set -buildvcs=false Signed-off-by: 'Stanislav Maksimov' <[email protected]> * address build errors Signed-off-by: 'Stanislav Maksimov' <[email protected]> * Revert "fix parameter name (#93)" (#100) This reverts commit 76159fd. * apply patch 12178 to v14 (#102) Signed-off-by: Priya Bibra <[email protected]> Signed-off-by: 'Priya Bibra' <[email protected]> * more workflows to use self-hosted runner * even more workflows to use self-hosted runner * partially switch upgrade-downgrade to self-hosted runner * Ejortegau/larger runners (#115) * Empty commit to trigger CI Signed-off-by: Eduardo J. Ortega U <[email protected]> * `slack-vitess-r14.0.5-dsdefense`: use larger runner Signed-off-by: Tim Vaillancourt <[email protected]> * Use runner group instead Signed-off-by: Tim Vaillancourt <[email protected]> * Rename group Signed-off-by: Tim Vaillancourt <[email protected]> * Move more jobs to runner group Signed-off-by: Tim Vaillancourt <[email protected]> * use vitess-ubuntu20 runner group Signed-off-by: Tim Vaillancourt <[email protected]> * Rever change of runner type for e2e ERS PRS new features heavy test Signed-off-by: Eduardo J. Ortega U <[email protected]> --------- Signed-off-by: Eduardo J. Ortega U <[email protected]> Signed-off-by: Tim Vaillancourt <[email protected]> Co-authored-by: Tim Vaillancourt <[email protected]> * Revert change of runner type for shardedrecovery_stress_verticalsplit_heavy. (#116) We do this because the test is taking a lot longer & failing in some cases with the larger runner. Signed-off-by: Eduardo J. Ortega U <[email protected]> * `slack-vitess-r14.0.5`: use dedicated larger runner (#113) * `slack-vitess-r14.0.5`: use dedicated larger runner Signed-off-by: Tim Vaillancourt <[email protected]> * fix fileNameFromPosition Signed-off-by: Tim Vaillancourt <[email protected]> * empty commit Signed-off-by: Tim Vaillancourt <[email protected]> * empty commit Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]> * `slack-vitess-r14.0.5`: allow conn overrides in consul topo (#111) * `slack-vitess-r14.0.5`: allow conn overrides in consul topo Signed-off-by: Tim Vaillancourt <[email protected]> * fix e2e test Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Dirkjan Bussink <[email protected]> Signed-off-by: 'Stanislav Maksimov' <[email protected]> Signed-off-by: Priya Bibra <[email protected]> Signed-off-by: 'Priya Bibra' <[email protected]> Signed-off-by: Eduardo J. Ortega U <[email protected]> Signed-off-by: Tim Vaillancourt <[email protected]> Co-authored-by: Dirkjan Bussink <[email protected]> Co-authored-by: Roderick Yao <[email protected]> Co-authored-by: pbibra <[email protected]> Co-authored-by: Eduardo J. Ortega U <[email protected]> Co-authored-by: Tim Vaillancourt <[email protected]>
maksimov
added a commit
that referenced
this pull request
Sep 13, 2023
* Cleanup usage of go.rice in favor of go:embed (vitessio#10956) * Cleanup usage of go.rice in favor of go:embed The usage of go.rice predates the availability of go:embed, but we should switch to using go:embed instead to ship specific assets like config files that we need. go.rice is also incompatible with Go 1.19 and while it might see a fix in the future, it seems better to go with the recommended Go approach that is available these days. Signed-off-by: Dirkjan Bussink <[email protected]> * Move vtctld to also use `go embed` instead of go.rice Signed-off-by: Dirkjan Bussink <[email protected]> * Remove last rice-box related comments Signed-off-by: Dirkjan Bussink <[email protected]> * Remove config moving This right now breaks building the actual tests since the tests might also end up loading the regular code which has a `go embed` and refers to the package with the config embeds. This doesn't mean that the config isn't properly included in the binaries. Also with using `go embed` we have a build time dependency on the files and we always know the latest is included, so we don't have the issue of potentially outdated files either. All in all, it seems simplest to remove this logic and trust that Go itself works as advertised. Signed-off-by: Dirkjan Bussink <[email protected]> * fix vtrootbin Signed-off-by: 'Stanislav Maksimov' <[email protected]> * update the build to 1.19.10 Signed-off-by: 'Stanislav Maksimov' <[email protected]> * update the workflows to 1.19.10 Signed-off-by: 'Stanislav Maksimov' <[email protected]> * update the docker image to 1.19.10 Signed-off-by: 'Stanislav Maksimov' <[email protected]> * update the bootstrap version to get docker to go 1.20.5 Signed-off-by: 'Stanislav Maksimov' <[email protected]> * use 1.18.7 for static checks Signed-off-by: 'Stanislav Maksimov' <[email protected]> * lower the build version requirement to allow static checks to pass Signed-off-by: 'Stanislav Maksimov' <[email protected]> * experiment with using old and new Go for a single workflow Signed-off-by: 'Stanislav Maksimov' <[email protected]> * use old and new Go for a upgrade/downgrade workflows Signed-off-by: 'Stanislav Maksimov' <[email protected]> * set -buildvcs=false Signed-off-by: 'Stanislav Maksimov' <[email protected]> * address build errors Signed-off-by: 'Stanislav Maksimov' <[email protected]> * Revert "fix parameter name (#93)" (#100) This reverts commit 76159fd. * apply patch 12178 to v14 (#102) Signed-off-by: Priya Bibra <[email protected]> Signed-off-by: 'Priya Bibra' <[email protected]> * more workflows to use self-hosted runner * even more workflows to use self-hosted runner * partially switch upgrade-downgrade to self-hosted runner * Ejortegau/larger runners (#115) * Empty commit to trigger CI Signed-off-by: Eduardo J. Ortega U <[email protected]> * `slack-vitess-r14.0.5-dsdefense`: use larger runner Signed-off-by: Tim Vaillancourt <[email protected]> * Use runner group instead Signed-off-by: Tim Vaillancourt <[email protected]> * Rename group Signed-off-by: Tim Vaillancourt <[email protected]> * Move more jobs to runner group Signed-off-by: Tim Vaillancourt <[email protected]> * use vitess-ubuntu20 runner group Signed-off-by: Tim Vaillancourt <[email protected]> * Rever change of runner type for e2e ERS PRS new features heavy test Signed-off-by: Eduardo J. Ortega U <[email protected]> --------- Signed-off-by: Eduardo J. Ortega U <[email protected]> Signed-off-by: Tim Vaillancourt <[email protected]> Co-authored-by: Tim Vaillancourt <[email protected]> * Revert change of runner type for shardedrecovery_stress_verticalsplit_heavy. (#116) We do this because the test is taking a lot longer & failing in some cases with the larger runner. Signed-off-by: Eduardo J. Ortega U <[email protected]> * `slack-vitess-r14.0.5`: use dedicated larger runner (#113) * `slack-vitess-r14.0.5`: use dedicated larger runner Signed-off-by: Tim Vaillancourt <[email protected]> * fix fileNameFromPosition Signed-off-by: Tim Vaillancourt <[email protected]> * empty commit Signed-off-by: Tim Vaillancourt <[email protected]> * empty commit Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]> * `slack-vitess-r14.0.5`: allow conn overrides in consul topo (#111) * `slack-vitess-r14.0.5`: allow conn overrides in consul topo Signed-off-by: Tim Vaillancourt <[email protected]> * fix e2e test Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Dirkjan Bussink <[email protected]> Signed-off-by: 'Stanislav Maksimov' <[email protected]> Signed-off-by: Priya Bibra <[email protected]> Signed-off-by: 'Priya Bibra' <[email protected]> Signed-off-by: Eduardo J. Ortega U <[email protected]> Signed-off-by: Tim Vaillancourt <[email protected]> Co-authored-by: Dirkjan Bussink <[email protected]> Co-authored-by: Roderick Yao <[email protected]> Co-authored-by: pbibra <[email protected]> Co-authored-by: Eduardo J. Ortega U <[email protected]> Co-authored-by: Tim Vaillancourt <[email protected]>
maksimov
added a commit
that referenced
this pull request
Sep 18, 2023
* Upgrade go slack vitess r14.0.5 (#91) * Cleanup usage of go.rice in favor of go:embed (vitessio#10956) * Cleanup usage of go.rice in favor of go:embed The usage of go.rice predates the availability of go:embed, but we should switch to using go:embed instead to ship specific assets like config files that we need. go.rice is also incompatible with Go 1.19 and while it might see a fix in the future, it seems better to go with the recommended Go approach that is available these days. Signed-off-by: Dirkjan Bussink <[email protected]> * Move vtctld to also use `go embed` instead of go.rice Signed-off-by: Dirkjan Bussink <[email protected]> * Remove last rice-box related comments Signed-off-by: Dirkjan Bussink <[email protected]> * Remove config moving This right now breaks building the actual tests since the tests might also end up loading the regular code which has a `go embed` and refers to the package with the config embeds. This doesn't mean that the config isn't properly included in the binaries. Also with using `go embed` we have a build time dependency on the files and we always know the latest is included, so we don't have the issue of potentially outdated files either. All in all, it seems simplest to remove this logic and trust that Go itself works as advertised. Signed-off-by: Dirkjan Bussink <[email protected]> * fix vtrootbin Signed-off-by: 'Stanislav Maksimov' <[email protected]> * update the build to 1.19.10 Signed-off-by: 'Stanislav Maksimov' <[email protected]> * update the workflows to 1.19.10 Signed-off-by: 'Stanislav Maksimov' <[email protected]> * update the docker image to 1.19.10 Signed-off-by: 'Stanislav Maksimov' <[email protected]> * update the bootstrap version to get docker to go 1.20.5 Signed-off-by: 'Stanislav Maksimov' <[email protected]> * use 1.18.7 for static checks Signed-off-by: 'Stanislav Maksimov' <[email protected]> * lower the build version requirement to allow static checks to pass Signed-off-by: 'Stanislav Maksimov' <[email protected]> * experiment with using old and new Go for a single workflow Signed-off-by: 'Stanislav Maksimov' <[email protected]> * use old and new Go for a upgrade/downgrade workflows Signed-off-by: 'Stanislav Maksimov' <[email protected]> * set -buildvcs=false Signed-off-by: 'Stanislav Maksimov' <[email protected]> * address build errors Signed-off-by: 'Stanislav Maksimov' <[email protected]> * Revert "fix parameter name (#93)" (#100) This reverts commit 76159fd. * apply patch 12178 to v14 (#102) Signed-off-by: Priya Bibra <[email protected]> Signed-off-by: 'Priya Bibra' <[email protected]> * more workflows to use self-hosted runner * even more workflows to use self-hosted runner * partially switch upgrade-downgrade to self-hosted runner * Ejortegau/larger runners (#115) * Empty commit to trigger CI Signed-off-by: Eduardo J. Ortega U <[email protected]> * `slack-vitess-r14.0.5-dsdefense`: use larger runner Signed-off-by: Tim Vaillancourt <[email protected]> * Use runner group instead Signed-off-by: Tim Vaillancourt <[email protected]> * Rename group Signed-off-by: Tim Vaillancourt <[email protected]> * Move more jobs to runner group Signed-off-by: Tim Vaillancourt <[email protected]> * use vitess-ubuntu20 runner group Signed-off-by: Tim Vaillancourt <[email protected]> * Rever change of runner type for e2e ERS PRS new features heavy test Signed-off-by: Eduardo J. Ortega U <[email protected]> --------- Signed-off-by: Eduardo J. Ortega U <[email protected]> Signed-off-by: Tim Vaillancourt <[email protected]> Co-authored-by: Tim Vaillancourt <[email protected]> * Revert change of runner type for shardedrecovery_stress_verticalsplit_heavy. (#116) We do this because the test is taking a lot longer & failing in some cases with the larger runner. Signed-off-by: Eduardo J. Ortega U <[email protected]> * `slack-vitess-r14.0.5`: use dedicated larger runner (#113) * `slack-vitess-r14.0.5`: use dedicated larger runner Signed-off-by: Tim Vaillancourt <[email protected]> * fix fileNameFromPosition Signed-off-by: Tim Vaillancourt <[email protected]> * empty commit Signed-off-by: Tim Vaillancourt <[email protected]> * empty commit Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]> * `slack-vitess-r14.0.5`: allow conn overrides in consul topo (#111) * `slack-vitess-r14.0.5`: allow conn overrides in consul topo Signed-off-by: Tim Vaillancourt <[email protected]> * fix e2e test Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Dirkjan Bussink <[email protected]> Signed-off-by: 'Stanislav Maksimov' <[email protected]> Signed-off-by: Priya Bibra <[email protected]> Signed-off-by: 'Priya Bibra' <[email protected]> Signed-off-by: Eduardo J. Ortega U <[email protected]> Signed-off-by: Tim Vaillancourt <[email protected]> Co-authored-by: Dirkjan Bussink <[email protected]> Co-authored-by: Roderick Yao <[email protected]> Co-authored-by: pbibra <[email protected]> Co-authored-by: Eduardo J. Ortega U <[email protected]> Co-authored-by: Tim Vaillancourt <[email protected]> * Upgrade go slack vitess r14.0.5 (#91) * Cleanup usage of go.rice in favor of go:embed (vitessio#10956) * Cleanup usage of go.rice in favor of go:embed The usage of go.rice predates the availability of go:embed, but we should switch to using go:embed instead to ship specific assets like config files that we need. go.rice is also incompatible with Go 1.19 and while it might see a fix in the future, it seems better to go with the recommended Go approach that is available these days. Signed-off-by: Dirkjan Bussink <[email protected]> * Move vtctld to also use `go embed` instead of go.rice Signed-off-by: Dirkjan Bussink <[email protected]> * Remove last rice-box related comments Signed-off-by: Dirkjan Bussink <[email protected]> * Remove config moving This right now breaks building the actual tests since the tests might also end up loading the regular code which has a `go embed` and refers to the package with the config embeds. This doesn't mean that the config isn't properly included in the binaries. Also with using `go embed` we have a build time dependency on the files and we always know the latest is included, so we don't have the issue of potentially outdated files either. All in all, it seems simplest to remove this logic and trust that Go itself works as advertised. Signed-off-by: Dirkjan Bussink <[email protected]> * fix vtrootbin Signed-off-by: 'Stanislav Maksimov' <[email protected]> * update the build to 1.19.10 Signed-off-by: 'Stanislav Maksimov' <[email protected]> * update the workflows to 1.19.10 Signed-off-by: 'Stanislav Maksimov' <[email protected]> * update the docker image to 1.19.10 Signed-off-by: 'Stanislav Maksimov' <[email protected]> * update the bootstrap version to get docker to go 1.20.5 Signed-off-by: 'Stanislav Maksimov' <[email protected]> * use 1.18.7 for static checks Signed-off-by: 'Stanislav Maksimov' <[email protected]> * lower the build version requirement to allow static checks to pass Signed-off-by: 'Stanislav Maksimov' <[email protected]> * experiment with using old and new Go for a single workflow Signed-off-by: 'Stanislav Maksimov' <[email protected]> * use old and new Go for a upgrade/downgrade workflows Signed-off-by: 'Stanislav Maksimov' <[email protected]> * set -buildvcs=false Signed-off-by: 'Stanislav Maksimov' <[email protected]> * address build errors Signed-off-by: 'Stanislav Maksimov' <[email protected]> * Revert "fix parameter name (#93)" (#100) This reverts commit 76159fd. * apply patch 12178 to v14 (#102) Signed-off-by: Priya Bibra <[email protected]> Signed-off-by: 'Priya Bibra' <[email protected]> * more workflows to use self-hosted runner * even more workflows to use self-hosted runner * partially switch upgrade-downgrade to self-hosted runner * Ejortegau/larger runners (#115) * Empty commit to trigger CI Signed-off-by: Eduardo J. Ortega U <[email protected]> * `slack-vitess-r14.0.5-dsdefense`: use larger runner Signed-off-by: Tim Vaillancourt <[email protected]> * Use runner group instead Signed-off-by: Tim Vaillancourt <[email protected]> * Rename group Signed-off-by: Tim Vaillancourt <[email protected]> * Move more jobs to runner group Signed-off-by: Tim Vaillancourt <[email protected]> * use vitess-ubuntu20 runner group Signed-off-by: Tim Vaillancourt <[email protected]> * Rever change of runner type for e2e ERS PRS new features heavy test Signed-off-by: Eduardo J. Ortega U <[email protected]> --------- Signed-off-by: Eduardo J. Ortega U <[email protected]> Signed-off-by: Tim Vaillancourt <[email protected]> Co-authored-by: Tim Vaillancourt <[email protected]> * Revert change of runner type for shardedrecovery_stress_verticalsplit_heavy. (#116) We do this because the test is taking a lot longer & failing in some cases with the larger runner. Signed-off-by: Eduardo J. Ortega U <[email protected]> * `slack-vitess-r14.0.5`: use dedicated larger runner (#113) * `slack-vitess-r14.0.5`: use dedicated larger runner Signed-off-by: Tim Vaillancourt <[email protected]> * fix fileNameFromPosition Signed-off-by: Tim Vaillancourt <[email protected]> * empty commit Signed-off-by: Tim Vaillancourt <[email protected]> * empty commit Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]> * `slack-vitess-r14.0.5`: allow conn overrides in consul topo (#111) * `slack-vitess-r14.0.5`: allow conn overrides in consul topo Signed-off-by: Tim Vaillancourt <[email protected]> * fix e2e test Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Dirkjan Bussink <[email protected]> Signed-off-by: 'Stanislav Maksimov' <[email protected]> Signed-off-by: Priya Bibra <[email protected]> Signed-off-by: 'Priya Bibra' <[email protected]> Signed-off-by: Eduardo J. Ortega U <[email protected]> Signed-off-by: Tim Vaillancourt <[email protected]> Co-authored-by: Dirkjan Bussink <[email protected]> Co-authored-by: Roderick Yao <[email protected]> Co-authored-by: pbibra <[email protected]> Co-authored-by: Eduardo J. Ortega U <[email protected]> Co-authored-by: Tim Vaillancourt <[email protected]> * Cleaning up bad merge * Fixing the build cmds --------- Signed-off-by: Dirkjan Bussink <[email protected]> Signed-off-by: 'Stanislav Maksimov' <[email protected]> Signed-off-by: Priya Bibra <[email protected]> Signed-off-by: 'Priya Bibra' <[email protected]> Signed-off-by: Eduardo J. Ortega U <[email protected]> Signed-off-by: Tim Vaillancourt <[email protected]> Co-authored-by: Dirkjan Bussink <[email protected]> Co-authored-by: Roderick Yao <[email protected]> Co-authored-by: pbibra <[email protected]> Co-authored-by: Eduardo J. Ortega U <[email protected]> Co-authored-by: Tim Vaillancourt <[email protected]>
timvaillancourt
added a commit
that referenced
this pull request
Apr 12, 2024
* `slack-vitess-r14.0.5`: allow conn overrides in consul topo Signed-off-by: Tim Vaillancourt <[email protected]> * fix e2e test Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]>
4 tasks
timvaillancourt
added a commit
that referenced
this pull request
Apr 16, 2024
* `slack-vitess-r14.0.5`: allow conn overrides in consul topo (#111) * `slack-vitess-r14.0.5`: allow conn overrides in consul topo Signed-off-by: Tim Vaillancourt <[email protected]> * fix e2e test Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]> * Update flags tests that didn't exist in v14 Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]>
timvaillancourt
added a commit
that referenced
this pull request
Jul 9, 2024
* `slack-vitess-r14.0.5`: allow conn overrides in consul topo (#111) * `slack-vitess-r14.0.5`: allow conn overrides in consul topo Signed-off-by: Tim Vaillancourt <[email protected]> * fix e2e test Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]> * Update flags tests that didn't exist in v14 Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]>
4 tasks
timvaillancourt
added a commit
that referenced
this pull request
Jul 9, 2024
* Make `Durabler` interface methods public (vitessio#15548) Signed-off-by: Tim Vaillancourt <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Co-authored-by: Manan Gupta <[email protected]> * Load `--grpc_auth_static_client_creds` file once (vitessio#15030) Signed-off-by: Tim Vaillancourt <[email protected]> * Limit concurrent creation of healthcheck gRPC connections (vitessio#15053) Signed-off-by: Tim Vaillancourt <[email protected]> * Filter by keyspace earlier in `tabletgateway`s `WaitForTablets(...)` (vitessio#15347) Signed-off-by: Tim Vaillancourt <[email protected]> * Use slack-15.0 as previous release Signed-off-by: Tim Vaillancourt <[email protected]> * empty commit Signed-off-by: Tim Vaillancourt <[email protected]> * force ci to run * Update GH Action runners Signed-off-by: Tim Vaillancourt <[email protected]> * test templates Signed-off-by: Tim Vaillancourt <[email protected]> * set GH access token in build Signed-off-by: Tim Vaillancourt <[email protected]> * Fix reparent old tests Signed-off-by: Tim Vaillancourt <[email protected]> * Remove CIs we don't need Signed-off-by: Tim Vaillancourt <[email protected]> * Remove CIs we don't need again Signed-off-by: Tim Vaillancourt <[email protected]> * Add private repo setup to upgrade_downgrade_test_backups_e2e.yml Signed-off-by: Tim Vaillancourt <[email protected]> * Add private repo setup to more CI Signed-off-by: Tim Vaillancourt <[email protected]> * remove CI skip logic for upstream stuff Signed-off-by: Tim Vaillancourt <[email protected]> * CODEOWNERS Signed-off-by: Tim Vaillancourt <[email protected]> * [release-19.0] Add timeout to all the contexts used for RPC calls in vtorc (vitessio#15991) (vitessio#16103) Signed-off-by: Manan Gupta <[email protected]> * `slack-vitess-r15.0.5`: forward-port consul topo limits PR #111 (#297) * `slack-vitess-r14.0.5`: allow conn overrides in consul topo (#111) * `slack-vitess-r14.0.5`: allow conn overrides in consul topo Signed-off-by: Tim Vaillancourt <[email protected]> * fix e2e test Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]> * Update flags tests that didn't exist in v14 Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]> * update vtcombo e2e Signed-off-by: Tim Vaillancourt <[email protected]> * Fix err with installing percona-xtrabackup-24 Signed-off-by: Tim Vaillancourt <[email protected]> * `slack-vitess-r15.0.5`: fix races in `Unit Test (Race)` CI, fix "old" reparent CIs (#356) * update vtcombo e2e test Signed-off-by: Tim Vaillancourt <[email protected]> * Fix bad merge conflict fix Signed-off-by: Tim Vaillancourt <[email protected]> * go mod tidy Signed-off-by: Tim Vaillancourt <[email protected]> * update vtcombo e2e test again Signed-off-by: Tim Vaillancourt <[email protected]> * [release-19.0] Upgrade the Golang version to `go1.22.5` (vitessio#16322) Signed-off-by: GitHub <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: frouioui <[email protected]> Co-authored-by: Florent Poinsard <[email protected]> * merge conflict fixes Signed-off-by: Tim Vaillancourt <[email protected]> * make vtadmin_web_proto_types Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: GitHub <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: Manan Gupta <[email protected]> Co-authored-by: Manan Gupta <[email protected]> Co-authored-by: vitess-bot <[email protected]> Co-authored-by: frouioui <[email protected]> Co-authored-by: Florent Poinsard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a copy of the v12 PR #108
This adds flags to tune the connection usage of the consul topo
cc @vmogilev / @rvrangel / @ejortegau
Related Issue(s)
#108
Checklist
Deployment Notes