add NOT_FOUND vstream error to retry but omit tablet group (#154)

slackhq · May 29, 2024 · c63ab98 · c63ab98
1 parent b3f3b93
commit c63ab98
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/go/vt/vtgate/vstream_manager.go b/go/vt/vtgate/vstream_manager.go
@@ -733,7 +733,8 @@ func (vs *vstream) shouldRetry(err error) (bool, bool) {
 
 	// If there is a GTIDSet Mismatch on the tablet, omit it from the candidate
 	// list in the TabletPicker on retry.
-	if errCode == vtrpcpb.Code_INVALID_ARGUMENT && strings.Contains(err.Error(), "GTIDSet Mismatch") {
+	if (errCode == vtrpcpb.Code_INVALID_ARGUMENT && strings.Contains(err.Error(), "GTIDSet Mismatch")) ||
+		errCode == vtrpc.Code_NOT_FOUND {
 		return true, true
 	}
 

diff --git a/go/vt/vtgate/vstream_manager_test.go b/go/vt/vtgate/vstream_manager_test.go
@@ -427,6 +427,13 @@ func TestVStreamRetriableErrors(t *testing.T) {
 			shouldRetry:  false,
 			ignoreTablet: false,
 		},
+		{
+			name:         "not found",
+			code:         vtrpcpb.Code_NOT_FOUND,
+			msg:          "",
+			shouldRetry:  true,
+			ignoreTablet: true,
+		},
 	}
 
 	commit := []*binlogdatapb.VEvent{