-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reestablish relays when last hop fails #1270
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As an FYI for viewers, a log line like this at the Lighthouse is indicative of this issue:
|
…nection is 'Estabslished' on successful handshake receipt
nbrownus
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to backport to v1.9 as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relays can break and never recover if, with the following setup:
I<->R<->C
the R<->C connection breaks, and the only traffic in the network is I<->C, not C->I.
This change updates host deletion work to mark associated relays as 'Disestablished', because we can't quite tell if they are still working or not. When host
I
finds its relayed connection is in this state, it will now re-send CreateRelayRequest messages to ensure the end-to-end relayed connection.Relay host behavior was also updated. Before, the Relay host would use the State status of relay peers to immediately return a CreateRelayResponse if the next hop is already in an Established state. This PR changes the Relay to always forward CreateRelayRequest messages along the path, and only terminal relay peers will generate the CreateRelayResponse message flow.