Use one version code for all apks

[linhpha]

We can move away from having separate version code for each build type now that we're publishing app bundle

This change should also help resolve issues with AGP 8.1 upgrade

[github-actions]

1. The code can be improved by removing the unnecessary use of variantOutput.abiString and VERSION_CODES map. Instead, a constant value can be used for the version code based on the ABI.

internal class ApkVersioningPlugin : Plugin<Project> {
    override fun apply(project: Project) {
        project.androidVariants.all { variant ->
            variant.outputs.all { output ->
                output.versionCode.setDisallowChanges(ApkVersioning.VERSION_CODE)
            }
        }
    }
}

private object ApkVersioning {
    const val VERSION_CODE: Int = 90000000 // Set the desired version code here
}

2. If you still want to use the VERSION_CODES map, you can simplify it by using a when statement instead of a map.

private object ApkVersioning {
    const val VERSION_CODE: Int = 90000000 // Set the desired version code here

    fun getVersionCode(abiString: String?): Int {
        return when (abiString) {
            "arm64-v8a" -> VERSION_CODE + 3
            "armeabi-v7a" -> VERSION_CODE + 2
            "x86" -> VERSION_CODE + 8
            "x86_64" -> VERSION_CODE + 9
            else -> VERSION_CODE
        }
    }
}

internal class ApkVersioningPlugin : Plugin<Project> {
    override fun apply(project: Project) {
        project.androidVariants.all { variant ->
            variant.outputs.all { output ->
                output.versionCode.setDisallowChanges(ApkVersioning.getVersionCode(output.abiString))
            }
        }
    }
}

3. If the VERSION_CODE is always the same, you can simplify the code further by directly setting the version code without using a separate object.

internal class ApkVersioningPlugin : Plugin<Project> {
    override fun apply(project: Project) {
        project.androidVariants.all { variant ->
            variant.outputs.all { output ->
                output.versionCode.setDisallowChanges(90000000) // Set the desired version code here
            }
        }
    }
}

[ZacSweers]

Let's drop this 10000000 and the VERSION_CODE magic constant and handle it internally in the slack repo's gradle.properties, no reason to impose this heh. Then we can just pass versionCodeProvider directly to the variantOutput.versionCode

[linhpha]

Removed the calculation here 37159ee

Per this change, we'll need to update the version code in release.version to 90012557 right?

[ZacSweers]

Yup exactly

[ZacSweers]

Lgtm. One possibly tricky thing is that we either need to do a release with this cherry-picked onto a branch from the previous non-kotlin 1.9 update or do them all at once. What do you think?

[linhpha]

Lgtm. One possibly tricky thing is that we either need to do a release with this cherry-picked onto a branch from the previous non-kotlin 1.9 update or do them all at once. What do you think?

I think I'd prefer the latter cause it's easier 😅 I've been testing locally the upgrade with this change and it should work 🤞

[ZacSweers]

Kk I'll take care of it