Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tests for Different Changelog Format with Non-Italicized Dates #492

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

kateliu20
Copy link
Contributor

@kateliu20 kateliu20 commented Jul 27, 2023

This is related to a previous PR that was just merged, about different formatting with italicized / non italicized entry dates. I created test cases in ChangelogParserNoItalicsTest.kt that are now passing because of the pushed change.

Here are the current tests in a different file, but the new tests are in this change.

This is to account for the different possible local date formats found in markdown files.
Screenshot 2023-07-27 at 1 08 34 PM
Screenshot 2023-07-27 at 1 08 17 PM

Here is the side by side comparison of the tests, just removing the "_" to see if the parser is able to still work with a different local date format:
Screenshot 2023-07-27 at 2 59 02 PM
Screenshot 2023-07-27 at 2 59 12 PM

@github-actions
Copy link

  1. Remove the unnecessary comments at the beginning of the file.
  2. Use a more descriptive name for the test class, such as "ChangelogParserTest".
  3. Use more meaningful test method names that describe the specific scenario being tested.
  4. Use a consistent indentation style throughout the code.
  5. Remove the unnecessary import statement for java.time.LocalDate.
  6. Use a more descriptive variable name for the input string in each test method.
  7. Use a more descriptive variable name for the expectedDate in each test method.
  8. Use a more descriptive variable name for the expectedString in each test method.
  9. Remove the unnecessary trimIndent() calls in the test methods.
  10. Use a consistent formatting style for the test method parameters and return types.
  11. Use a consistent formatting style for the test method assertions.
  12. Consider using a test framework like JUnit 5 instead of JUnit 4 for more advanced testing features.
  13. Consider adding more test cases to cover different scenarios and edge cases.

@kateliu20 kateliu20 added the skate 🛹 Anything related to the Skate IntelliJ plugin label Jul 27, 2023
@kateliu20 kateliu20 requested a review from arpita184 July 27, 2023 21:58
@kateliu20 kateliu20 added this pull request to the merge queue Jul 27, 2023
Merged via the queue into main with commit f07470b Jul 27, 2023
3 checks passed
@kateliu20 kateliu20 deleted the kl/whats_new_italics_test branch July 27, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skate 🛹 Anything related to the Skate IntelliJ plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants