-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify CI #429
Simplify CI #429
Conversation
We don't really ever set other versions and having a consistent name is required in order to mark those checks as `required` for merge queue
Overall, the code looks good. Here are some suggestions for improvement:
These are just some suggestions for improvement. Feel free to adapt them to your specific use case and coding style. |
strategy: | ||
fail-fast: false | ||
matrix: | ||
ci_java_version: ['20'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
matrix.ci_java_version is still being used in 2 locations. Can you please resolve those references as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 07f36eb
Here are the changes I would suggest to improve the code:
|
We don't really ever set other versions and having a consistent name is required in order to mark those checks as
required
for merge queue