CHANGELOG parser by date #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 27, 2023 14:50
ZacSweers
reviewed
Jun 28, 2023
| return LOCAL_DATE_REGEX.matches(this) | ||
| } | ||
|
|
||
| object ChangelogParser { |
There was a problem hiding this comment.
Let's add a doc to this
There was a problem hiding this comment.
Doc added: 37f1b00
There was a problem hiding this comment.
I think it landed in the wrong place? I don't see it on ChangelogParser
There was a problem hiding this comment.
I added a doc to ChangelogParser.kt
skate-plugin/src/main/kotlin/com/slack/sgp/intellij/ChangelogParser.kt
Outdated
Show resolved
Hide resolved
skate-plugin/src/test/kotlin/com/slack/sgp/intellij/ChangeLogParserTest.kt
Show resolved
Hide resolved
skate-plugin/src/test/kotlin/com/slack/sgp/intellij/ChangeLogParserTest.kt
Outdated
Show resolved
Hide resolved
skate-plugin/src/test/kotlin/com/slack/sgp/intellij/ChangeLogParserTest.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Zac Sweers <[email protected]>
Co-authored-by: Zac Sweers <[email protected]>
…ange_log_parser # Conflicts: # skate-plugin/src/test/kotlin/com/slack/sgp/intellij/ChangeLogParserTest.kt
added 2 commits
June 28, 2023 15:57
arpita184
reviewed
Jun 29, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
added 2 commits
June 30, 2023 15:19
ZacSweers
reviewed
Jun 30, 2023
skate-plugin/src/main/kotlin/com/slack/sgp/intellij/ChangelogParser.kt
Outdated
Show resolved
Hide resolved
skate-plugin/src/test/kotlin/com/slack/sgp/intellij/ChangeLogParserTest.kt
Show resolved
Hide resolved
| return LOCAL_DATE_REGEX.matches(this) | ||
| } | ||
|
|
||
| object ChangelogParser { |
There was a problem hiding this comment.
I think it landed in the wrong place? I don't see it on ChangelogParser
added 2 commits
June 30, 2023 16:43
…it is not the latest entry
arpita184
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parses the CHANGELOG.md file by date, and only shows the updated file if the latest entry does not match the previous entry by date.