UI Changes with Text Area (Shift + Enter, Starting and Continuing Conversation) #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kateliu20
changed the title
linhpha
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the Jewel update, there were some changes to TextArea API, so I modified it to handle a Shift + Enter and Enter functionality. Shift + Enter will add a new line without sending, while Enter will send the message. I set the
keyboardOptions = KeyboardOptions(imeAction = ImeAction.None)as a way to remove the default enter functionality TextArea has.Screenshare.-.2024-10-01.2_50_35.PM.mp4
UPDATE: I also added the functionality where if the conversation started already, then it will say "continue the conversation" instead of 'start" every time. The cursor looks off but I asked in #jewel in the kotlin-lang workspace for any tips to remedy that.
Screenshare.-.2024-10-01.3_51_25.PM.mp4
(also still waiting on calling the API, which is why that isn't here)