Add passing test for creating json input

slackhq · Sep 18, 2024 · 9f9d447 · 9f9d447
1 parent 9cbda30
commit 9f9d447
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 19 deletions.
diff --git a/skate-plugin/project-gen/src/jvmMain/kotlin/slack/tooling/aibot/ChatPresenter.kt b/skate-plugin/project-gen/src/jvmMain/kotlin/slack/tooling/aibot/ChatPresenter.kt
@@ -45,7 +45,7 @@ class ChatPresenter : Presenter<ChatScreen.State> {
             println("ChatPresenter: Fetching a quote")
             val response = chatBotActionService.executeCommand(event.message)
             println("ChatPresenter: Received response: $newMessage")
-            messages = messages + Message(role = user, response)
+            messages = messages + Message(role = bot, response)
           }
         }
       }

diff --git a/skate-plugin/project-gen/src/jvmMain/kotlin/slack/tooling/aibot/ChatWindowUi.kt b/skate-plugin/project-gen/src/jvmMain/kotlin/slack/tooling/aibot/ChatWindowUi.kt
@@ -149,9 +149,7 @@ private fun ConversationField(modifier: Modifier = Modifier, onSendMessage: (Str
 
 @Composable
 private fun ChatBubble(message: Message, modifier: Modifier = Modifier) {
-  val user = "user"
-  val isMe = message.role == user
-
+  val isMe = message.role == "user"
   Box(
     Modifier.wrapContentWidth()
       .padding(8.dp)

diff --git a/skate-plugin/src/test/kotlin/slack/tooling/aibot/ChatBotActionServiceTest.kt b/skate-plugin/src/test/kotlin/slack/tooling/aibot/ChatBotActionServiceTest.kt
@@ -20,16 +20,9 @@ import com.google.gson.Gson
 import org.junit.Test
 
 class ChatBotActionServiceTest {
-  @Test
-  fun `say 1+1 equals 2`() {
-    val result = 1 + 1
-    val actual = 2
-    assertThat(actual).isEqualTo(result)
-  }
-
   @Test
   fun `test creating the Json input`() {
-    val question = "What's the capital of Canada"
+    val question = "Why is the sky blue?"
 
     val result = createJsonInput(question)
 
@@ -39,27 +32,30 @@ class ChatBotActionServiceTest {
             "messages": [
             {
                 "role": "user",
-                "content": "What's the capital of Canada"
+                "content": "Why is the sky blue?"
             }
         ],
         "source": "curl",
-        "max_tokens": 2048
+        "max_tokens": 512
+        }
     """
         .trimIndent()
 
-    println("expected is ${expectedJson}")
-    println("actual is ${result}")
+    val trimmedExpected = expectedJson.replace(Regex("\\s"), "")
+    val trimmedResult = result.replace(Regex("\\s"), "")
+    println("expected is ${trimmedExpected}")
+    println("actual is ${trimmedResult}")
 
-    assertThat(result).isEqualTo(expectedJson)
+    assertThat(trimmedResult).isEqualTo(trimmedExpected)
   }
 
   private fun createJsonInput(question: String): String {
     val user = "user"
     val gsonInput = Gson()
     val content =
-      Content(messages = listOf(Message(role = user, question)), source = "curl", max_tokens = 2048)
+      Content(messages = listOf(Message(role = user, question)), source = "curl", max_tokens = 512)
 
-    val jsonContent = gsonInput.toJson(content)
+    val jsonContent = gsonInput.toJson(content).toString()
     return jsonContent
   }