Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: include the slack health score as part of ci tests #346

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented Oct 2, 2024

Summary

This PR adds the 🏥 slackapi/slack-health-score to this action as part of regular check ups!

Hopes to fix strangeness that happens when adding this action another PR. I'm hoping this fixes missing commits, but am unsure if this is a real fix 😳

Notes

Please forgive the misuse of a diff but these are the errors shown in the other run:

> Run slackapi/[email protected]
    with:
      codecov_token: ***
      github_token: ***
      extension: js
    env:
      EVENT_URL: https://github.com/slackapi/slack-github-action/pull/333
  Using SHA: 7c719bb2a1a67ec8972d7edd09a24c26856f306f
  Pinging codecov API for coverage data...
- Error: Failed to retrieve codecov commits
- Error: FetchError: Unauthorized
- Warning: Directories to be included not specified
- Error: Error: spawnSync /bin/sh ENOBUFS
- Error: child_process execSync failed to execute
  {
    "comments": [],
    "coverageMisses": 0
  }
  Using SHA: 7c719bb2a1a67ec8972d7edd09a24c26856f306f
  -0

More notes

  • Formatting of the main.yml is left to another PR or future change - hoping to keep this diff small ✨

Requirements

@zimeg zimeg added tests github_actions Pull requests that update GitHub Actions code labels Oct 2, 2024
@zimeg zimeg added this to the 1.x milestone Oct 2, 2024
@zimeg zimeg self-assigned this Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.91%. Comparing base (9bcc222) to head (4bac3f3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #346   +/-   ##
=======================================
  Coverage   97.91%   97.91%           
=======================================
  Files           2        2           
  Lines          96       96           
=======================================
  Hits           94       94           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zimeg
Copy link
Member Author

zimeg commented Oct 2, 2024

@filmaj 🙏 Thanks for such speed in this review! I'm excited to see what'll happen on merge to main with a pull_request_target 😳

Let's find out! 🚀

@zimeg zimeg merged commit 2c86117 into slackapi:main Oct 2, 2024
4 checks passed
@zimeg zimeg deleted the ci-slack-health-score branch October 2, 2024 19:01
@zimeg
Copy link
Member Author

zimeg commented Oct 2, 2024

🤔 Hmmm no immediate results, but it's also true that the commit on main is the first with the health score. Perchance a run with the next commit changes things? I'll be keeping close watch on this 👁️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants