Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1409 Socket Mode: Slow message consumption when listeners do not immediately return ack() #1411

Merged
merged 1 commit into from
Jan 8, 2025
+296 −54

Fix #1409 Socket Mode: Slow message consumption when listeners do not…

b3a3273
Select commit
Loading
Failed to load commit list.
Merged

Fix #1409 Socket Mode: Slow message consumption when listeners do not immediately return ack() #1411

Fix #1409 Socket Mode: Slow message consumption when listeners do not…
b3a3273
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Jan 7, 2025 in 1s

36.66% of diff hit (target 30.00%)

View this Pull Request on Codecov

36.66% of diff hit (target 30.00%)

Annotations

Check warning on line 86 in bolt-jakarta-socket-mode/src/main/java/com/slack/api/bolt/jakarta_socket_mode/SocketModeApp.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

bolt-jakarta-socket-mode/src/main/java/com/slack/api/bolt/jakarta_socket_mode/SocketModeApp.java#L86 

Added line #L86 was not covered by tests

Check warning on line 117 in bolt-jakarta-socket-mode/src/main/java/com/slack/api/bolt/jakarta_socket_mode/SocketModeApp.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

bolt-jakarta-socket-mode/src/main/java/com/slack/api/bolt/jakarta_socket_mode/SocketModeApp.java#L115-L117 

Added lines #L115 - L117 were not covered by tests

Check warning on line 122 in bolt-jakarta-socket-mode/src/main/java/com/slack/api/bolt/jakarta_socket_mode/SocketModeApp.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

bolt-jakarta-socket-mode/src/main/java/com/slack/api/bolt/jakarta_socket_mode/SocketModeApp.java#L120-L122 

Added lines #L120 - L122 were not covered by tests

Check warning on line 124 in bolt-jakarta-socket-mode/src/main/java/com/slack/api/bolt/jakarta_socket_mode/SocketModeApp.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

bolt-jakarta-socket-mode/src/main/java/com/slack/api/bolt/jakarta_socket_mode/SocketModeApp.java#L124 

Added line #L124 was not covered by tests

Check warning on line 134 in bolt-jakarta-socket-mode/src/main/java/com/slack/api/bolt/jakarta_socket_mode/SocketModeApp.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

bolt-jakarta-socket-mode/src/main/java/com/slack/api/bolt/jakarta_socket_mode/SocketModeApp.java#L134 

Added line #L134 was not covered by tests

Check warning on line 146 in bolt-jakarta-socket-mode/src/main/java/com/slack/api/bolt/jakarta_socket_mode/SocketModeApp.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

bolt-jakarta-socket-mode/src/main/java/com/slack/api/bolt/jakarta_socket_mode/SocketModeApp.java#L145-L146 

Added lines #L145 - L146 were not covered by tests

Check warning on line 154 in bolt-jakarta-socket-mode/src/main/java/com/slack/api/bolt/jakarta_socket_mode/SocketModeApp.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

bolt-jakarta-socket-mode/src/main/java/com/slack/api/bolt/jakarta_socket_mode/SocketModeApp.java#L153-L154 

Added lines #L153 - L154 were not covered by tests

Check warning on line 169 in bolt-jakarta-socket-mode/src/main/java/com/slack/api/bolt/jakarta_socket_mode/SocketModeApp.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

bolt-jakarta-socket-mode/src/main/java/com/slack/api/bolt/jakarta_socket_mode/SocketModeApp.java#L169 

Added line #L169 was not covered by tests

Check warning on line 185 in bolt-jakarta-socket-mode/src/main/java/com/slack/api/bolt/jakarta_socket_mode/SocketModeApp.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

bolt-jakarta-socket-mode/src/main/java/com/slack/api/bolt/jakarta_socket_mode/SocketModeApp.java#L184-L185 

Added lines #L184 - L185 were not covered by tests

Check warning on line 212 in bolt-jakarta-socket-mode/src/main/java/com/slack/api/bolt/jakarta_socket_mode/SocketModeApp.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

bolt-jakarta-socket-mode/src/main/java/com/slack/api/bolt/jakarta_socket_mode/SocketModeApp.java#L212 

Added line #L212 was not covered by tests

Check warning on line 259 in bolt-jakarta-socket-mode/src/main/java/com/slack/api/bolt/jakarta_socket_mode/SocketModeApp.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

bolt-jakarta-socket-mode/src/main/java/com/slack/api/bolt/jakarta_socket_mode/SocketModeApp.java#L254-L259 

Added lines #L254 - L259 were not covered by tests

Check warning on line 86 in bolt-socket-mode/src/main/java/com/slack/api/bolt/socket_mode/SocketModeApp.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

bolt-socket-mode/src/main/java/com/slack/api/bolt/socket_mode/SocketModeApp.java#L86 

Added line #L86 was not covered by tests

Check warning on line 122 in bolt-socket-mode/src/main/java/com/slack/api/bolt/socket_mode/SocketModeApp.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

bolt-socket-mode/src/main/java/com/slack/api/bolt/socket_mode/SocketModeApp.java#L120-L122 

Added lines #L120 - L122 were not covered by tests

Check warning on line 124 in bolt-socket-mode/src/main/java/com/slack/api/bolt/socket_mode/SocketModeApp.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

bolt-socket-mode/src/main/java/com/slack/api/bolt/socket_mode/SocketModeApp.java#L124 

Added line #L124 was not covered by tests

Check warning on line 134 in bolt-socket-mode/src/main/java/com/slack/api/bolt/socket_mode/SocketModeApp.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

bolt-socket-mode/src/main/java/com/slack/api/bolt/socket_mode/SocketModeApp.java#L134 

Added line #L134 was not covered by tests

Check warning on line 146 in bolt-socket-mode/src/main/java/com/slack/api/bolt/socket_mode/SocketModeApp.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

bolt-socket-mode/src/main/java/com/slack/api/bolt/socket_mode/SocketModeApp.java#L145-L146 

Added lines #L145 - L146 were not covered by tests

Check warning on line 154 in bolt-socket-mode/src/main/java/com/slack/api/bolt/socket_mode/SocketModeApp.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

bolt-socket-mode/src/main/java/com/slack/api/bolt/socket_mode/SocketModeApp.java#L153-L154 

Added lines #L153 - L154 were not covered by tests

Check warning on line 179 in bolt-socket-mode/src/main/java/com/slack/api/bolt/socket_mode/SocketModeApp.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

bolt-socket-mode/src/main/java/com/slack/api/bolt/socket_mode/SocketModeApp.java#L178-L179 

Added lines #L178 - L179 were not covered by tests

Check warning on line 197 in bolt-socket-mode/src/main/java/com/slack/api/bolt/socket_mode/SocketModeApp.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

bolt-socket-mode/src/main/java/com/slack/api/bolt/socket_mode/SocketModeApp.java#L197 

Added line #L197 was not covered by tests

Check warning on line 207 in bolt-socket-mode/src/main/java/com/slack/api/bolt/socket_mode/SocketModeApp.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

bolt-socket-mode/src/main/java/com/slack/api/bolt/socket_mode/SocketModeApp.java#L206-L207 

Added lines #L206 - L207 were not covered by tests

Check warning on line 216 in bolt-socket-mode/src/main/java/com/slack/api/bolt/socket_mode/SocketModeApp.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

bolt-socket-mode/src/main/java/com/slack/api/bolt/socket_mode/SocketModeApp.java#L216 

Added line #L216 was not covered by tests

Check warning on line 221 in bolt-socket-mode/src/main/java/com/slack/api/bolt/socket_mode/SocketModeApp.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

bolt-socket-mode/src/main/java/com/slack/api/bolt/socket_mode/SocketModeApp.java#L220-L221 

Added lines #L220 - L221 were not covered by tests

Check warning on line 259 in bolt-socket-mode/src/main/java/com/slack/api/bolt/socket_mode/SocketModeApp.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

bolt-socket-mode/src/main/java/com/slack/api/bolt/socket_mode/SocketModeApp.java#L259 

Added line #L259 was not covered by tests

Check warning on line 306 in bolt-socket-mode/src/main/java/com/slack/api/bolt/socket_mode/SocketModeApp.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

bolt-socket-mode/src/main/java/com/slack/api/bolt/socket_mode/SocketModeApp.java#L301-L306 

Added lines #L301 - L306 were not covered by tests
View more details on Codecov