Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1378 AsyncRateLimitExecutor ignores teamId set in MethodsClientImpl provided #1379

Closed
wants to merge 1 commit into from

Conversation

seratch
Copy link
Member

@seratch seratch commented Sep 28, 2024

This pull request resolves #1378

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:slack-api-client project:slack-api-client labels Sep 28, 2024
@seratch seratch added this to the 1.44.0 milestone Sep 28, 2024
@seratch seratch self-assigned this Sep 28, 2024
Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.53%. Comparing base (c8ce619) to head (497e54c).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1379   +/-   ##
=========================================
  Coverage     74.53%   74.53%           
  Complexity     4324     4324           
=========================================
  Files           472      472           
  Lines         13491    13491           
  Branches       1377     1377           
=========================================
  Hits          10056    10056           
  Misses         2622     2622           
  Partials        813      813           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seratch
Copy link
Member Author

seratch commented Sep 30, 2024

I found that there is no necessity to make this change, so let me close this PR now

@seratch seratch closed this Sep 30, 2024
@seratch seratch removed this from the 1.44.0 milestone Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:slack-api-client project:slack-api-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AsyncRateLimitExecutor ignores teamId set in MethodsClientImpl provided
1 participant