added test to validate that js file is used over invalid TS file #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shapirone
requested changes
Jun 28, 2022
| @@ -31,6 +31,21 @@ Deno.test("LoadFunctionModule function", async (t) => { | |||
| ); | |||
| }); | |||
|
|
|||
| await t.step("should load the js file if ts file is invalid", async () => { | |||
| const tsModule = await LoadFunctionModule( | |||
There was a problem hiding this comment.
This results in a jsModule rather than a tsModule
| assertEquals( | ||
| tsModule.default.name, | ||
| "wackyJS", | ||
| "typescript file invalid, js file loaded", |
There was a problem hiding this comment.
This should be a Custom Error Message in case this assertion doesn't work. Right now this reads like a success message.
shapirone
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added a new test to verify that load-function-module will load a js file over a bad ts file. #16
Requirements (place an
xin each[ ])