Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest generated changes #51

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 1, 2024

🚀 Automated Pull Request: Coded-Connectors Update

This PR brings the latest changes to coded-connectors, fueled by Slack's latest data. Developers can now access the newest features effortlessly.

GitHub prevents triggering a workflow from a workflow, the checks on this pull request will not be triggered automatically 😅
To trigger the checks on this pull request:

  1. close the pull request
  2. reopen the pull request

Github-Actions 🤖

@github-actions github-actions bot added the enhancement New feature or request label Jul 1, 2024
@github-actions github-actions bot requested a review from a team as a code owner July 1, 2024 00:12
@filmaj filmaj mentioned this pull request Jul 2, 2024
@filmaj filmaj closed this Jul 2, 2024
@filmaj filmaj reopened this Jul 2, 2024
Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge and release this as a 1.0 new major version.

@@ -9,7 +9,6 @@ export default DefineConnector({
properties: {
workspace_gid: { type: Schema.types.string, title: "Workspace" },
project: { type: Schema.types.string, title: "Project" },
assignee_section: { type: Schema.types.string, title: "Section" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a breaking change for workflow functionality (turns out you can specify bogus properties in a workflow configuration just fine), but this does break things for coded workflow apps (because TypeScript will not compile). So this will warrant a new major version.

required: [
"project_name",
"company_name",
"owner",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new required property, but without it, this connector would fail. So, technically a breaking change, but practically a fixing change.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good 👍

@WilliamBergamin WilliamBergamin merged commit 376bc86 into main Jul 2, 2024
7 checks passed
@WilliamBergamin WilliamBergamin deleted the generate_2024-07-01_00-11 branch July 2, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants