-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest generated changes #51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge and release this as a 1.0 new major version.
@@ -9,7 +9,6 @@ export default DefineConnector({ | |||
properties: { | |||
workspace_gid: { type: Schema.types.string, title: "Workspace" }, | |||
project: { type: Schema.types.string, title: "Project" }, | |||
assignee_section: { type: Schema.types.string, title: "Section" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a breaking change for workflow functionality (turns out you can specify bogus properties in a workflow configuration just fine), but this does break things for coded workflow apps (because TypeScript will not compile). So this will warrant a new major version.
required: [ | ||
"project_name", | ||
"company_name", | ||
"owner", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new required property, but without it, this connector would fail. So, technically a breaking change, but practically a fixing change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good 👍
🚀 Automated Pull Request: Coded-Connectors Update
This PR brings the latest changes to coded-connectors, fueled by Slack's latest data. Developers can now access the newest features effortlessly.
GitHub prevents triggering a workflow from a workflow, the checks on this pull request will not be triggered automatically 😅
To trigger the checks on this pull request:
Github-Actions 🤖