Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Quart adapter (resolving #619) #620

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

sonnens
Copy link

@sonnens sonnens commented Mar 20, 2022

Add an adapter for Quart ( #619 )

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@CLAassistant
Copy link

CLAassistant commented Mar 20, 2022

CLA assistant check
All committers have signed the CLA.

@seratch seratch added this to the 1.x milestone Mar 20, 2022
@seratch
Copy link
Member

seratch commented Mar 20, 2022

Hi @sonnens, thanks for submitting the PR!

There are a few things that we would like you to add:

As I mentioned at #619 (comment), we need your (and/or other community members') help for this addition more than usual. It'd be appreciated if you could understand this.

@seratch seratch self-assigned this Mar 20, 2022
@seratch seratch changed the title add quart adapter Add Quart adapter (resolving #619) Mar 20, 2022

async def handle(self, req: Request) -> Response:
if req.method == "GET":
if self.app.oauth_flow is not None:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Can we add this to one line below like
if req.method == "GET" and self.app.oauth_flow is not None

@seratch seratch marked this pull request as draft October 28, 2022 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants