Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose auto acknowledge for function handlers #1173

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

WilliamBergamin
Copy link
Contributor

This PR exposes the auto_acknowledge flag at the at the function listener initialization level. This will allow the developer to build functions that call complete or fail before ack() (responding) the the slack request.

This will be used for dynamic options support

NOTE: the 3 second time out may prove to be a limitation since function have a timeout of 15 seconds, a follow up PR may be needed to imporve this behavior

Category

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.09%. Comparing base (56d5ca3) to head (a4421e6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1173      +/-   ##
==========================================
+ Coverage   92.02%   92.09%   +0.07%     
==========================================
  Files         195      195              
  Lines        6631     6631              
==========================================
+ Hits         6102     6107       +5     
+ Misses        529      524       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seratch seratch added this to the 1.21.0 milestone Oct 3, 2024
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; Thanks for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants