Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/tests: move to biome, v4 linter fixes #2259

Merged
merged 78 commits into from
Oct 2, 2024
Merged

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Sep 15, 2024

To be merged into #2254 - seperating out the linting changes from the rest for ease of reviewing #2254

Changes

  • 🔪 eslint and nyc, 🤗 biome and c8
  • "safe" biome linter fixes applied
  • some quality-of-life additions to .gitignore
  • test folders were moved around a bit, mostly due to the testing expanding in size and there being multiple different kinds of tests:
    • tests now exist under the test/ directory
    • test/unit/ contains all unit tests, powered by Mocha
    • test/types contains all type tests, powered by tsd. Love was put into these tests. Expanding tsd tests is the best way to ensure we don't regress on TypeScript-developer-experience-related bits like autocomplete.
  • the old App-context-types.spec.ts file was removed and instead those 'unit' tests were ported over to actual type tests (using tsd)
  • a lot of type casting was removed where it would not introduce breakage. we should stay clear of type casting (e.g. as Whatever) as much as possible and lean on the type system to do its thing.
  • test helpers under test/unit/helpers were expanded: now have more dummy event creators that lean into the type system rather than avoid it
  • examples changes:
    • linted and ensured the examples/ work with bolt v4. also added the custom-receiver example to the list of examples TS integration testing w/ bolt
    • removed hubot-example

TODO

  • update all examples

@filmaj filmaj added the tests M-T: Testing work only label Sep 15, 2024
@filmaj filmaj added this to the 4.0.0 milestone Sep 15, 2024
@filmaj filmaj self-assigned this Sep 15, 2024
@filmaj filmaj mentioned this pull request Sep 15, 2024
6 tasks
@filmaj filmaj force-pushed the bolt-four-linting branch 5 times, most recently from 820ef1f to 148046a Compare September 26, 2024 20:51
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 93.95349% with 52 lines in your changes missing coverage. Please review.

Please upload report for BASE (bolt-four@6ab4e47). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/App.ts 92.24% 18 Missing ⚠️
src/receivers/HTTPModuleFunctions.ts 91.14% 17 Missing ⚠️
src/receivers/HTTPReceiver.ts 81.08% 14 Missing ⚠️
src/receivers/AwsLambdaReceiver.ts 95.00% 1 Missing ⚠️
src/receivers/ExpressReceiver.ts 98.70% 1 Missing ⚠️
src/receivers/SocketModeReceiver.ts 97.36% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             bolt-four    #2259   +/-   ##
============================================
  Coverage             ?   90.79%           
============================================
  Files                ?       20           
  Lines                ?     5576           
  Branches             ?      602           
============================================
  Hits                 ?     5063           
  Misses               ?      505           
  Partials             ?        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@filmaj filmaj marked this pull request as ready for review October 2, 2024 19:56
@filmaj filmaj merged commit 78c945b into bolt-four Oct 2, 2024
18 checks passed
@filmaj filmaj deleted the bolt-four-linting branch October 2, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests M-T: Testing work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant