-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci/tests: move to biome, v4 linter fixes #2259
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filmaj
force-pushed
the
bolt-four-linting
branch
5 times, most recently
from
September 26, 2024 20:51
820ef1f
to
148046a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## bolt-four #2259 +/- ##
============================================
Coverage ? 90.79%
============================================
Files ? 20
Lines ? 5576
Branches ? 602
============================================
Hits ? 5063
Misses ? 505
Partials ? 8 ☔ View full report in Codecov by Sentry. |
filmaj
force-pushed
the
bolt-four-linting
branch
from
September 27, 2024 17:02
a2747e4
to
b67446f
Compare
filmaj
force-pushed
the
bolt-four-linting
branch
from
September 27, 2024 18:17
b67446f
to
0a92c35
Compare
filmaj
force-pushed
the
bolt-four-linting
branch
from
October 1, 2024 13:32
0a92c35
to
0442712
Compare
… integration CI check
filmaj
force-pushed
the
bolt-four-linting
branch
from
October 2, 2024 19:22
0442712
to
ffaf37a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged into #2254 - seperating out the linting changes from the rest for ease of reviewing #2254
Changes
node:
; fixes Usenode:
-prefixed imports for Node.js core modules #1803.gitignore
test/
directorytest/unit/
contains all unit tests, powered by Mochatest/types
contains all type tests, powered bytsd
. Love was put into these tests. Expandingtsd
tests is the best way to ensure we don't regress on TypeScript-developer-experience-related bits like autocomplete.App-context-types.spec.ts
file was removed and instead those 'unit' tests were ported over to actual type tests (usingtsd
)as Whatever
) as much as possible and lean on the type system to do its thing.test/unit/helpers
were expanded: now have more dummy event creators that lean into the type system rather than avoid itexamples/
work with bolt v4. also added thecustom-receiver
example to the list of examples TS integration testing w/ boltTODO