fix: options constraint has wrong type definition #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @nemanjastanic to sign the Salesforce Inc. Contributor License Agreement. |
seratch
added
the
needs info
|
I've changed this PR to draft state. We're still trying to understand what this PR could resolve. Please refer to #1939 for the discussion. |
seratch
requested changes
Sep 11, 2023
seratch
added
bug
seratch
added a commit
to seratch/bolt-js
that referenced
this pull request
Sep 11, 2023
|
Hey @seratch! Sorry for being super late on the update here, just got back from a lengthy vacation :D I made the changes you asked for! |
seratch
requested changes
Oct 2, 2023
|
I just merged the missing change in OptionsConstraints interface part. Once the CI builds pass, we'll merge this PR. |
Codecov Report
@@ Coverage Diff @@
## main #1940 +/- ##
=======================================
Coverage 82.21% 82.21%
=======================================
Files 18 18
Lines 1524 1524
Branches 438 438
=======================================
Hits 1253 1253
Misses 175 175
Partials 96 96
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
seratch
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Apply correct type definitions for the
constraintsargument in theoptionsfunction.Fixes #1939
Requirements (place an
xin each[ ])