-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing null unions for plain text and static select block action… #1915
Conversation
2bfbef8
to
7ded116
Compare
Hmm, I'm unsure why the build is failing 🤔 Seems to be because of an import order on a file I haven't touched as part of the PR. I did just get #1910 approved and merged based on the same state of |
@GovernmentHack I believe it was the change that was introduced in #1910 that is causing this failure. |
Is #1910 the cause? the errors seem to indicate some sort of import error:
|
@GovernmentHack #1910 was the cause for the unit tests to fail - if you run just the unit tests locally, you should be able to reproduce (at least, I was able to reproduce locally). |
7ded116
to
9c51b63
Compare
@filmaj Sure thing! rebased and pushed. Thank you again for the help! |
Codecov Report
@@ Coverage Diff @@
## main #1915 +/- ##
=======================================
Coverage 82.18% 82.18%
=======================================
Files 18 18
Lines 1521 1521
Branches 436 436
=======================================
Hits 1250 1250
Misses 175 175
Partials 96 96 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@GovernmentHack thanks for the PR but first let's figure out what the issue is, I'd like to continue the conversation in #1914 before we make any additional moves or changes in this PR. |
Per our conversation in the issue, I'm good for this PR to be rejected 👍 |
… types
Summary
Add the missing type definitions to fix Issue 1914 #1914
Requirements (place an
x
in each[ ]
)