-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support npm specifiers #33
Conversation
Should this be created as a |
this PR or the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably use a versioned types
package and also move it into a deps.ts
if it exists?
This PR will also conflict with #34 FYI.
functions/open_form/blocks.ts
Outdated
@@ -8,7 +8,7 @@ import { | |||
MultiUsersSelect, | |||
Option, | |||
SectionBlock, | |||
} from "https://cdn.skypack.dev/@slack/types?dts"; | |||
} from "npm:@slack/types"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd version this, the current version is 2.9.0. I am planning on releasing a 3.0 version soon-ish which will include breaking changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but def should be tested with an actual slack deploy
/ at least a deno-hooks build
hook invocation to see if esbuild can handle it or not.
Would be nice to add that to samples' CI, too: can the project be built using the deno build
hook?
🟢 tested with |
Type of change (place an x in the [ ] that applies)
Summary
This PR aims to update the version of the
deno-slack-hooks
package and enable the project to usenpm
specifiers to import packagesThis also resolves #32
Testing
slack deploy
Requirements