Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: allow the test task to pass if no tests can be found #47

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

slack-samples[bot]
Copy link
Contributor

@slack-samples slack-samples bot commented Oct 31, 2024

Automatically synchronizing changes to the deno.jsonc file across all samples

@@ -28,6 +28,6 @@
},
"lock": false,
"tasks": {
"test": "deno fmt --check && deno lint && deno test --allow-read"
"test": "deno fmt --check && deno lint && deno test --allow-read --allow-none"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed this was removed to be compatible with Deno 2 - super casual mention @filmaj

I think this is a good change to share across other samples (removing the flag from deno.jsonc) but will want to make sure we have tests in place or can otherwise avoid problems in CI before fanning out this removal 👻

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More context on the allow-none flag: denoland/deno#24752

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super interesting, thanks for sharing! It seems like --permit-no-files is the alternative, but I'm still hoping that we can include a test with all of our samples 😉

@zimeg zimeg changed the title feat: remove archived deno samples from the automations feat: allow the test task to pass if no tests can be found Oct 31, 2024
@zimeg zimeg changed the title feat: allow the test task to pass if no tests can be found build: allow the test task to pass if no tests can be found Oct 31, 2024
@zimeg
Copy link
Member

zimeg commented Oct 31, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants