Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gather a random gif from the giphy connector #39

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented May 25, 2024

Type of change

  • New sample
  • New feature
  • Bug fix
  • Documentation

Summary

This PR replaces the Find a GIF custom function with the Giphy connector and uses the custom function to format the kudo_message with better formatting.

A few other changes happen too:

  • selecting a kudo_vibe is required in the form since something is needed for connector input
  • the link trigger defaults to the channel ID it's used in to save this selection
  • the custom message formatting function fixes a bug where only the first line of a multiline message was quoted
  • the custom message formatting also gathers just the link from the connector response- an example is in tests

Reviewers

Clone the sample:

$ slack create kudo -t slack-samples/deno-give-kudos -b feat-giphy-connector
$ cd kudo
$ slack deploy  # Gather a link trigger

Then test the workflow in a channel. GIF results can be unexpected and prompting the connector is an art. Open to all suggestion here!

Requirements

  • I’ve checked my submission against the Samples Checklist to ensure it complies with all standards
  • I have ensured the changes I am contributing align with existing patterns and have tested and linted my code
  • I've read and agree to the Code of Conduct

@zimeg zimeg added bug Something isn't working enhancement New feature or request labels May 25, 2024
@zimeg zimeg self-assigned this May 25, 2024
README.md Outdated Show resolved Hide resolved

Deno.test("Mention the kind kudo receiver", async () => {
const inputs = {
doer_of_good_deeds: "USLACKBOT",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait you can just call slackbot like this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 all praises to the kind @USLACKBOT - it's a great placeholder that means something meaningful! To me it means everything.

Copy link

@lukegalbraithrussell lukegalbraithrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can update the site tutorial! 🏴‍☠️

@zimeg
Copy link
Member Author

zimeg commented Jun 27, 2024

@lukegalbraithrussell appreciate the review and suggestions! The suggestions are great as always 🙌

And huge thanks for tutorial updates! Please let me know if I can help or should hold off on merging this or whatever makes the most sense. I defer to thee powerful mind 🧠 ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants