Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL on message to enable giphy preview #35

Merged

Conversation

tiagostutz
Copy link
Contributor

Type of change (place an x in the [ ] that applies)

  • New sample
  • New feature
  • Bug fix
  • Documentation

Summary

Fixes #34 .
Adds angle brackets <> to the giphy URL so it is properly displayed as preview on the message sent.

I couldn't find the "Samples Checklist" to check the standards

Requirements (place an x in each [ ] that applies)

  • I’ve checked my submission against the Samples Checklist to ensure it complies with all standards
  • I have ensured the changes I am contributing align with existing patterns and have tested and linted my code
  • I've read and agree to the Code of Conduct

Copy link

salesforce-cla bot commented Apr 1, 2024

Thanks for the contribution! Before we can merge this, we need @tiagostutz to sign the Salesforce Inc. Contributor License Agreement.

@tiagostutz tiagostutz closed this Apr 1, 2024
@tiagostutz tiagostutz force-pushed the add-angle-bracket-to-giphy-url branch from f49e67f to 94eaf04 Compare April 1, 2024 21:12
@tiagostutz tiagostutz reopened this Apr 1, 2024
@zimeg zimeg added the bug Something isn't working label Apr 1, 2024
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiagostutz awesomeness! Really great fix. Thanks for sending it in 👏 😄

@zimeg zimeg merged commit d7c67f5 into slack-samples:main Apr 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Giphy message not being displayed
2 participants