Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't treat asterisks in list items as italic in Markdown #528

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

rspeicher
Copy link
Contributor

Fixes an issue where asterisks used for list items were converted to underscores.

Before:

  1) Slack::Messages::Formatting#markdown doesn't treat list items as text formatting
     Failure/Error: expect(formatting.markdown(msg)).to eq msg
     
       expected: "Une liste:\n\n* Article 1\n* Article 2\n* Article 3\n"
            got: "Une liste:\n\n_ Article 1\n_ Article 2\n* Article 3\n"
     
       (compared using ==)
     
       Diff:
       @@ -1,6 +1,6 @@
        Une liste:
        
       -* Article 1
       -* Article 2
       +_ Article 1
       +_ Article 2
        * Article 3
       
     # ./spec/slack/messages/formatting_spec.rb:161:in `block (3 levels) in <top (required)>'

Introduced in #520.

Fixes an issue where asterisks used for list items were converted to
underscores.
@coveralls
Copy link

coveralls commented Nov 7, 2024

Pull Request Test Coverage Report for Build 11729294352

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on rs-asterisk-lists at 89.336%

Totals Coverage Status
Change from base Build 11707538954: 89.3%
Covered Lines: 5395
Relevant Lines: 6039

💛 - Coveralls

@dblock
Copy link
Collaborator

dblock commented Nov 7, 2024

Perfect, thank you.

@dblock dblock merged commit 4d5d8da into slack-ruby:master Nov 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants