Fix goreleaser action #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we've moved the project under an Org, rather than set a more permissive value for GITHUB_TOKENs for all our repositories, we'll adjust this specific job to include the permissions needed for it to create releases.
The flag --rm-dist is now --clean
|
@rk295 @raed-shomali once either of you reviews and approves I'll handle merging and then we can cut 0.1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving our project to an organization, the way permissions are handled is slightly different so we need to call out which permissions our jobs need in order to create our releases automatically.
This also fixes a deprecation issue with goreleaser, which changes the
--rm-distflag to--cleanand forces the Go version to match our minimum of 1.21.