Milestone-1 TCP-Transport. #536
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a part of bigger and unfinished tcp-transport PR. Here: - Fix of tcp-transport itself - it did not send laddr during Dial so on Accept on another edge was broken - Fix of memoryPubKeyTable: reverse search of pk was broken - FilePubKeyTable - simplified, now composed from memoryPubKeyTable - tests of tcp-transport - under no_ci tags because they need prepared IP addresses - .travis-ci now prepares IP aliases for tests
Excluding the last task defined in skycoin/skywire#501 - everything is completed. It was already done by most part a long time before. The most hard part is in the last task.
evanlinjin
suggested changes
Aug 27, 2019
|
Fixes requested by Evan - done. |
|
Remerged with mainnet-milestone-1. Fixed tests for tcp-transport |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excluding the last task defined in skycoin/skywire#501 - everything is completed.
It was already done by most part a long time before.
The most hard part is in the last task.