Skip to content

fix: address some static code analysis issues, exposed by the latest analyzer #13

fix: address some static code analysis issues, exposed by the latest analyzer

fix: address some static code analysis issues, exposed by the latest analyzer #13

Triggered via pull request November 18, 2023 18:15
Status Success
Total duration 6m 54s
Artifacts 2

main.yml

on: pull_request
determine-version
19s
determine-version
build (v4.2.1-pr87.8)
2m 3s
build (v4.2.1-pr87.8)
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
build (v4.2.1-pr87.8): src/MockHttp/Responses/IResponseBehavior.cs#L7
Rename type name ResponseHandlerDelegate so that it does not end in 'Delegate' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
build (v4.2.1-pr87.8): src/MockHttp/Responses/IResponseBehavior.cs#L22
In virtual/interface member IResponseBehavior.HandleAsync(MockHttpRequestContext, HttpResponseMessage, ResponseHandlerDelegate, CancellationToken), rename parameter next so that it no longer conflicts with the reserved language keyword 'Next'. Using a reserved keyword as the name of a parameter on a virtual/interface member makes it harder for consumers in other languages to override/implement the member. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1716)
build (v4.2.1-pr87.8): src/MockHttp/Http/DataEscapingHelper.cs#L53
'string.Replace(string, string?)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'MockHttp.Http.DataEscapingHelper.UnescapeData(string)' with a call to 'string.Replace(string, string?, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
build (v4.2.1-pr87.8): src/MockHttp/Responses/IResponseBehavior.cs#L7
Rename type name ResponseHandlerDelegate so that it does not end in 'Delegate' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
build (v4.2.1-pr87.8): src/MockHttp/Responses/IResponseBehavior.cs#L22
In virtual/interface member IResponseBehavior.HandleAsync(MockHttpRequestContext, HttpResponseMessage, ResponseHandlerDelegate, CancellationToken), rename parameter next so that it no longer conflicts with the reserved language keyword 'Next'. Using a reserved keyword as the name of a parameter on a virtual/interface member makes it harder for consumers in other languages to override/implement the member. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1716)
build (v4.2.1-pr87.8): src/MockHttp/Responses/IResponseBehavior.cs#L7
Rename type name ResponseHandlerDelegate so that it does not end in 'Delegate' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
build (v4.2.1-pr87.8): src/MockHttp/Responses/IResponseBehavior.cs#L22
In virtual/interface member IResponseBehavior.HandleAsync(MockHttpRequestContext, HttpResponseMessage, ResponseHandlerDelegate, CancellationToken), rename parameter next so that it no longer conflicts with the reserved language keyword 'Next'. Using a reserved keyword as the name of a parameter on a virtual/interface member makes it harder for consumers in other languages to override/implement the member. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1716)
build (v4.2.1-pr87.8): src/MockHttp/HttpMockException.cs#L39
Provide a message for the ObsoleteAttribute that marks .ctor as Obsolete (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1041)
build (v4.2.1-pr87.8): src/MockHttp/Responses/IResponseBehavior.cs#L7
Rename type name ResponseHandlerDelegate so that it does not end in 'Delegate' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
build (v4.2.1-pr87.8): src/MockHttp/Responses/IResponseBehavior.cs#L22
In virtual/interface member IResponseBehavior.HandleAsync(MockHttpRequestContext, HttpResponseMessage, ResponseHandlerDelegate, CancellationToken), rename parameter next so that it no longer conflicts with the reserved language keyword 'Next'. Using a reserved keyword as the name of a parameter on a virtual/interface member makes it harder for consumers in other languages to override/implement the member. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1716)

Artifacts

Produced during runtime
Name Size
build Expired
66.4 MB
release-4.2.1-pr87.8 Expired
1000 KB