Skip to content

fix: address some static code analysis issues, exposed by the latest analyzer #139

fix: address some static code analysis issues, exposed by the latest analyzer

fix: address some static code analysis issues, exposed by the latest analyzer #139

Triggered via pull request November 18, 2023 18:15
@skwasjerskwasjer
opened #87
Status Success
Total duration 4m 52s
Artifacts

sonarcloud.yml

on: pull_request_target
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
analysis: src/MockHttp/Responses/IResponseBehavior.cs#L7
Rename type name ResponseHandlerDelegate so that it does not end in 'Delegate' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
analysis: src/MockHttp/Responses/IResponseBehavior.cs#L22
In virtual/interface member IResponseBehavior.HandleAsync(MockHttpRequestContext, HttpResponseMessage, ResponseHandlerDelegate, CancellationToken), rename parameter next so that it no longer conflicts with the reserved language keyword 'Next'. Using a reserved keyword as the name of a parameter on a virtual/interface member makes it harder for consumers in other languages to override/implement the member. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1716)
analysis: src/MockHttp/Matchers/HttpHeadersMatcher.cs#L114
'string.Replace(string, string)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'MockHttp.Matchers.HttpHeadersMatcher.ToString()' with a call to 'string.Replace(string, string, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
analysis: src/MockHttp/Http/HttpHeaderEqualityComparer.cs#L66
Collection-specific "Exists" method should be used instead of the "Any" extension. (https://rules.sonarsource.com/csharp/RSPEC-6605)
analysis: src/MockHttp/Responses/IResponseBehavior.cs#L7
Rename type name ResponseHandlerDelegate so that it does not end in 'Delegate' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
analysis: src/MockHttp/Responses/IResponseBehavior.cs#L22
In virtual/interface member IResponseBehavior.HandleAsync(MockHttpRequestContext, HttpResponseMessage, ResponseHandlerDelegate, CancellationToken), rename parameter next so that it no longer conflicts with the reserved language keyword 'Next'. Using a reserved keyword as the name of a parameter on a virtual/interface member makes it harder for consumers in other languages to override/implement the member. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1716)
analysis: src/MockHttp/Http/HttpHeaderEqualityComparer.cs#L66
Collection-specific "Exists" method should be used instead of the "Any" extension. (https://rules.sonarsource.com/csharp/RSPEC-6605)
analysis: src/MockHttp/Http/DataEscapingHelper.cs#L53
'string.Replace(string, string?)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'MockHttp.Http.DataEscapingHelper.UnescapeData(string)' with a call to 'string.Replace(string, string?, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
analysis: src/MockHttp/Responses/IResponseBehavior.cs#L7
Rename type name ResponseHandlerDelegate so that it does not end in 'Delegate' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
analysis: src/MockHttp/Responses/IResponseBehavior.cs#L22
In virtual/interface member IResponseBehavior.HandleAsync(MockHttpRequestContext, HttpResponseMessage, ResponseHandlerDelegate, CancellationToken), rename parameter next so that it no longer conflicts with the reserved language keyword 'Next'. Using a reserved keyword as the name of a parameter on a virtual/interface member makes it harder for consumers in other languages to override/implement the member. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1716)