Skip to content

Address several static code analysis warnings #43

Address several static code analysis warnings

Address several static code analysis warnings #43

Triggered via pull request November 18, 2023 02:19
Status Success
Total duration 7m 38s
Artifacts

codeql-analysis.yml

on: pull_request
Matrix: Analyze
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
Analyze (csharp): src/MockHttp/Responses/IResponseBehavior.cs#L7
Rename type name ResponseHandlerDelegate so that it does not end in 'Delegate' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
Analyze (csharp): src/MockHttp/Responses/IResponseBehavior.cs#L22
In virtual/interface member IResponseBehavior.HandleAsync(MockHttpRequestContext, HttpResponseMessage, ResponseHandlerDelegate, CancellationToken), rename parameter next so that it no longer conflicts with the reserved language keyword 'Next'. Using a reserved keyword as the name of a parameter on a virtual/interface member makes it harder for consumers in other languages to override/implement the member. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1716)
Analyze (csharp): src/MockHttp/Responses/HttpHeaderBehavior.cs#L89
Modify 'TryAdd' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)
Analyze (csharp): src/MockHttp/Http/HttpHeaderEqualityComparer.cs#L70
Call the ArgumentOutOfRangeException constructor that contains a message and/or paramName parameter (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208)
Analyze (csharp): src/MockHttp/Responses/IResponseBehavior.cs#L7
Rename type name ResponseHandlerDelegate so that it does not end in 'Delegate' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
Analyze (csharp): src/MockHttp/Responses/IResponseBehavior.cs#L22
In virtual/interface member IResponseBehavior.HandleAsync(MockHttpRequestContext, HttpResponseMessage, ResponseHandlerDelegate, CancellationToken), rename parameter next so that it no longer conflicts with the reserved language keyword 'Next'. Using a reserved keyword as the name of a parameter on a virtual/interface member makes it harder for consumers in other languages to override/implement the member. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1716)
Analyze (csharp): src/MockHttp/Responses/HttpHeaderBehavior.cs#L89
Modify 'TryAdd' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)
Analyze (csharp): src/MockHttp/Http/HttpHeaderEqualityComparer.cs#L70
Call the ArgumentOutOfRangeException constructor that contains a message and/or paramName parameter (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208)
Analyze (csharp): src/MockHttp/Matchers/HttpHeadersMatcher.cs#L114
'string.Replace(string, string)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'MockHttp.Matchers.HttpHeadersMatcher.ToString()' with a call to 'string.Replace(string, string, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
Analyze (csharp): src/MockHttp/Responses/IResponseBehavior.cs#L7
Rename type name ResponseHandlerDelegate so that it does not end in 'Delegate' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)