ci: switch fully to GitHub actions instead of AppVeyor #40
Annotations
10 warnings
Analyze (csharp):
src/MockHttp/Matchers/ContentMatcher.cs#L50
Properties should not return arrays (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1819)
|
Analyze (csharp):
src/MockHttp/Responses/IResponseBehavior.cs#L7
Rename type name ResponseHandlerDelegate so that it does not end in 'Delegate' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
|
Analyze (csharp):
src/MockHttp/Threading/ConcurrentCollection.cs#L79
Exception type System.IndexOutOfRangeException is reserved by the runtime (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
|
Analyze (csharp):
src/MockHttp/Responses/IResponseBehavior.cs#L22
In virtual/interface member IResponseBehavior.HandleAsync(MockHttpRequestContext, HttpResponseMessage, ResponseHandlerDelegate, CancellationToken), rename parameter next so that it no longer conflicts with the reserved language keyword 'Next'. Using a reserved keyword as the name of a parameter on a virtual/interface member makes it harder for consumers in other languages to override/implement the member. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1716)
|
Analyze (csharp):
src/MockHttp/Extensions/ResponseBuilderExtensions.cs#L204
Consider calling ConfigureAwait on the awaited task (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2007)
|
Analyze (csharp):
src/MockHttp/Responses/HttpHeaderBehavior.cs#L89
Modify 'TryAdd' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)
|
Analyze (csharp):
src/MockHttp/Responses/HttpHeaderBehavior.cs#L10
Change type of field 'HeadersWithSingleValueOnly' from 'System.Collections.Generic.ISet<string>' to 'System.Collections.Generic.HashSet<string>' for improved performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1859)
|
Analyze (csharp):
src/MockHttp/RequestMatching.cs#L73
Prefer comparing 'Count' to 0 rather than using 'Any()', both for clarity and for performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1860)
|
Analyze (csharp):
src/MockHttp/NetworkLatency.cs#L20
Random is an insecure random number generator. Use cryptographically secure random number generators when randomness is required for security. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca5394)
|
Analyze (csharp):
src/MockHttp/Http/DataEscapingHelper.cs#L53
'string.Replace(string, string?)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'MockHttp.Http.DataEscapingHelper.UnescapeData(string)' with a call to 'string.Replace(string, string?, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
|