ci: attempt to fix random AppDomain unloads in CI on macos/mono #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sabling AppDomain altogether.
skwasjer
force-pushed
the
fix/xunit_app_domain_unload
branch
from
2174915 to
0cbcb07
Compare
|
|
Seriously contemplating nuking the CI tests on Mono/.NET 4.6.2. With this change, the appdomain unload exception seems gone, but now other CI errors start randomly occurring. Restarting the job, it just passes, flaky as hell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables xunit's AppDomain logic.
Hopefully this resolves the random CI failures related to loading satellite assemblies (for resource files) on Mono/.NET 4.6.2.
All other frameworks were unaffected.