fix: when enumerating registry, order by country code

skwasjer · Nov 20, 2024 · 3bc4b8f · 3bc4b8f
1 parent 5e813a7
commit 3bc4b8f
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/src/IbanNet/Registry/IbanRegistry.cs b/src/IbanNet/Registry/IbanRegistry.cs
@@ -36,7 +36,10 @@ public IbanRegistry()
     }
 
     /// <inheritdoc />
-    public IEnumerator<IbanCountry> GetEnumerator() => Dictionary.Values.GetEnumerator();
+    public IEnumerator<IbanCountry> GetEnumerator()
+    {
+        return Dictionary.Values.OrderBy(c => c.TwoLetterISORegionName).GetEnumerator();
+    }
 
     IEnumerator IEnumerable.GetEnumerator() => GetEnumerator();
 

diff --git a/test/IbanNet.Tests/Registry/IbanRegistryTests.cs b/test/IbanNet.Tests/Registry/IbanRegistryTests.cs
@@ -167,4 +167,16 @@ public void Given_that_registry_has_been_hydrated_when_adding_another_provider_t
         // Assert
         sut.Providers.Should().HaveCount(1);
     }
+
+    [Fact]
+    public void Registry_should_be_ordered_by_country_code()
+    {
+        var reg = new IbanRegistry { Providers = { new SwiftRegistryProvider() } };
+
+        // Act
+        var countryCodes = reg.Select(c => c.TwoLetterISORegionName).ToList();
+
+        // Assert
+        countryCodes.Should().BeInAscendingOrder();
+    }
 }