-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to configure log scope key #68
Conversation
Codecov Report
Additional details and impacted files
|
@skwasjer is there something else I need to do to get this merged? I see that the automated workflows are waiting for something but I don't know if I should do anything about that |
@laurynasr no, I just have not had time to look at your proposal yet, will probably do over the weekend. Thanks for the submission. |
src/Correlate.DependencyInjection/IHttpClientBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. The only thing stopping the merge is some missing coverage on the new AddCorrelate()
registration extension.
Kudos, SonarCloud Quality Gate passed! |
Thanks! |
Allow to configure the log scope key for correlation ID property. This allows using a different key, such as
ActivityId
instead of hardcodedCorrelationId
.The default is
CorrelationId
as previously; custom key can be set when composing the application withAddCorrelate
: