Skip to content

Commit

Permalink
chore!: remove .NET 6 target as it is EOL
Browse files Browse the repository at this point in the history
  • Loading branch information
skwasjer committed Dec 15, 2024
1 parent 6407054 commit b084d18
Show file tree
Hide file tree
Showing 12 changed files with 15 additions and 28 deletions.
6 changes: 1 addition & 5 deletions Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,8 @@
<PackageVersion_Microsoft_Extensions>9.0.0</PackageVersion_Microsoft_Extensions>
</PropertyGroup>

<PropertyGroup Condition="'$(TargetFramework)'!='net9.0' And '$(TargetFramework)'!='net6.0'">
<PropertyGroup Condition="'$(TargetFramework)'!='net9.0'">
<PackageVersion_Microsoft_Extensions>8.0.0</PackageVersion_Microsoft_Extensions>
</PropertyGroup>

<PropertyGroup Condition="'$(TargetFramework)'=='net6.0'">
<PackageVersion_Microsoft_Extensions>6.0.0</PackageVersion_Microsoft_Extensions>
</PropertyGroup>

</Project>
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ services.AddSingleton<ICorrelationIdFactory, RequestIdentifierCorrelationIdFacto

## Alternatives for more advanced Distributed Tracing

Please consider that .NET Core 3.1 and up now has built-in support for [W3C TraceContext](https://github.com/w3c/trace-context) ([blog](https://devblogs.microsoft.com/aspnet/improvements-in-net-core-3-0-for-troubleshooting-and-monitoring-distributed-apps/)) and that there are other distributed tracing libraries with more functionality than Correlate. Personally, I am using `System.Diagnostics.ActivitySource` and OpenTelemetry in my professional work.
Please consider that since .NET Core 3.1 and up there is built-in support for [W3C TraceContext](https://github.com/w3c/trace-context) ([blog](https://devblogs.microsoft.com/aspnet/improvements-in-net-core-3-0-for-troubleshooting-and-monitoring-distributed-apps/)) and that there are other distributed tracing libraries with more functionality than Correlate. Personally, I am using `System.Diagnostics.ActivitySource` and OpenTelemetry in my professional work.

- [OpenTelemetry](https://opentelemetry.io/)
- [Jaeger](https://www.jaegertracing.io/)
Expand All @@ -202,16 +202,16 @@ Please consider that .NET Core 3.1 and up now has built-in support for [W3C Trac
## More info

### Supported .NET targets
- .NET 6.0, .NET 8.0
- .NET 9.0, .NET 8.0
- .NET Standard 2.0

### ASP.NET Core support
- ASP.NET Core 6.0/8.0
- ASP.NET Core 9.0/8.0

### Build/test requirements
- Visual Studio 2022
- .NET 9 SDK
- .NET 8 SDK
- .NET 6 SDK
- .NET 3.1 SDK

#### Contributions
Expand Down
2 changes: 1 addition & 1 deletion src/Correlate.Abstractions/Correlate.Abstractions.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net9.0;net8.0;net6.0;netstandard2.0</TargetFrameworks>
<TargetFrameworks>net9.0;net8.0;netstandard2.0</TargetFrameworks>
<TargetFrameworks Condition="'$(NetPreview)'=='true'">$(TargetFrameworks);netx.0</TargetFrameworks>
<RootNamespace>Correlate</RootNamespace>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/Correlate.AspNetCore/Correlate.AspNetCore.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net9.0;net8.0;net6.0</TargetFrameworks>
<TargetFrameworks>net9.0;net8.0</TargetFrameworks>
<TargetFrameworks Condition="'$(NetPreview)'=='true'">$(TargetFrameworks);netx.0</TargetFrameworks>
<RootNamespace>Correlate</RootNamespace>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/Correlate.Core/Correlate.Core.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net9.0;net8.0;net6.0;netstandard2.0</TargetFrameworks>
<TargetFrameworks>net9.0;net8.0;netstandard2.0</TargetFrameworks>
<TargetFrameworks Condition="'$(NetPreview)'=='true'">$(TargetFrameworks);netx.0</TargetFrameworks>
<RootNamespace>Correlate</RootNamespace>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net9.0;net8.0;net6.0;netstandard2.0</TargetFrameworks>
<TargetFrameworks>net9.0;net8.0;netstandard2.0</TargetFrameworks>
<TargetFrameworks Condition="'$(NetPreview)'=='true'">$(TargetFrameworks);netx.0</TargetFrameworks>
</PropertyGroup>

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk.Web">

<PropertyGroup>
<TargetFrameworks>net9.0;net8.0;net6.0</TargetFrameworks>
<TargetFrameworks>net9.0;net8.0</TargetFrameworks>
<TargetFrameworks Condition="'$(NetPreview)'=='true'">$(TargetFrameworks);netx.0</TargetFrameworks>
<IsTestProject>true</IsTestProject>
<RootNamespace>Correlate</RootNamespace>
Expand All @@ -17,11 +17,6 @@
<Serilog_AspNetCore>8.0.0</Serilog_AspNetCore>
</PropertyGroup>

<PropertyGroup Condition="'$(TargetFramework)'=='net6.0'">
<Microsoft_AspNetCore_Mvc_Testing>6.0.21</Microsoft_AspNetCore_Mvc_Testing>
<Serilog_AspNetCore>6.1.0</Serilog_AspNetCore>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="$(Microsoft_AspNetCore_Mvc_Testing)" />
<PackageReference Include="Serilog.AspNetCore" Version="$(Serilog_AspNetCore)" />
Expand Down
2 changes: 1 addition & 1 deletion test/Correlate.Benchmarks/Correlate.Benchmarks.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFrameworks>net9.0;net8.0;net6.0</TargetFrameworks>
<TargetFrameworks>net9.0;net8.0</TargetFrameworks>
<TargetFrameworks Condition="'$(NetPreview)'=='true'">$(TargetFrameworks);netx.0</TargetFrameworks>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
Expand Down
2 changes: 1 addition & 1 deletion test/Correlate.Benchmarks/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,5 @@ Intel Core i7-8700K CPU 3.70GHz (Coffee Lake), 1 CPU, 12 logical and 6 physical
To run the benchmark:
```
cd ./test/Correlate.Benchmarks
dotnet run -c Release -f net8.0 --runtimes net80 net60
dotnet run -c Release -f net9.0 --runtimes net90 net80
```
2 changes: 1 addition & 1 deletion test/Correlate.Core.Tests/Correlate.Core.Tests.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net9.0;net8.0;net6.0;netcoreapp3.1</TargetFrameworks>
<TargetFrameworks>net9.0;net8.0;netcoreapp3.1</TargetFrameworks>
<TargetFrameworks Condition="'$(NetPreview)'=='true'">$(TargetFrameworks);netx.0</TargetFrameworks>
<IsTestProject>true</IsTestProject>
<RootNamespace>Correlate</RootNamespace>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net9.0;net8.0;net6.0;netcoreapp3.1</TargetFrameworks>
<TargetFrameworks>net9.0;net8.0;netcoreapp3.1</TargetFrameworks>
<TargetFrameworks Condition="'$(NetPreview)'=='true'">$(TargetFrameworks);netx.0</TargetFrameworks>
<IsTestProject>true</IsTestProject>
<RootNamespace>Correlate.DependencyInjection</RootNamespace>
Expand Down
6 changes: 1 addition & 5 deletions test/Correlate.Testing/Correlate.Testing.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net9.0;net8.0;net6.0;netstandard2.1</TargetFrameworks>
<TargetFrameworks>net9.0;net8.0;netstandard2.1</TargetFrameworks>
<TargetFrameworks Condition="'$(NetPreview)'=='true'">$(TargetFrameworks);netx.0</TargetFrameworks>
<IsTestProject>false</IsTestProject>
</PropertyGroup>
Expand All @@ -10,10 +10,6 @@
<Serilog_Extensions_Logging>8.0.0</Serilog_Extensions_Logging>
</PropertyGroup>

<PropertyGroup Condition="'$(TargetFramework)'=='net6.0'">
<Serilog_Extensions_Logging>3.1.0</Serilog_Extensions_Logging>
</PropertyGroup>

<PropertyGroup Condition="$(TargetFramework.StartsWith('netstandard2')) Or '$(TargetFramework)'=='netcoreapp3.1'">
<Serilog_Extensions_Logging>3.1.0</Serilog_Extensions_Logging>
</PropertyGroup>
Expand Down

0 comments on commit b084d18

Please sign in to comment.