Skip to content

Commit

Permalink
test: replace .NET Core 3.1 with .NET 4.6.2 to avoid EOL warnings/tes…
Browse files Browse the repository at this point in the history
…t failures in CI
  • Loading branch information
skwasjer committed Dec 15, 2024
1 parent 6407054 commit 306507a
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 8 deletions.
2 changes: 1 addition & 1 deletion test/Correlate.Core.Tests/Correlate.Core.Tests.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net9.0;net8.0;net6.0;netcoreapp3.1</TargetFrameworks>
<TargetFrameworks>net9.0;net8.0;net6.0;net462</TargetFrameworks>
<TargetFrameworks Condition="'$(NetPreview)'=='true'">$(TargetFrameworks);netx.0</TargetFrameworks>
<IsTestProject>true</IsTestProject>
<RootNamespace>Correlate</RootNamespace>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net9.0;net8.0;net6.0;netcoreapp3.1</TargetFrameworks>
<TargetFrameworks>net9.0;net8.0;net6.0;net462</TargetFrameworks>
<TargetFrameworks Condition="'$(NetPreview)'=='true'">$(TargetFrameworks);netx.0</TargetFrameworks>
<IsTestProject>true</IsTestProject>
<RootNamespace>Correlate.DependencyInjection</RootNamespace>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,7 @@ protected override IEnumerable<ExpectedRegistration> TestCases()

// AddHttpMessageHandler with options:
yield return new ExpectedRegistration<IConfigureOptions<CorrelateClientOptions>, ConfigureNamedOptions<CorrelateClientOptions>>(ServiceLifetime.Singleton);
#if NETCOREAPP3_1_OR_GREATER
yield return new ExpectedRegistration<IConfigureOptions<HttpClientFactoryOptions>>(ServiceLifetime.Singleton);
#else
yield return new ExpectedRegistration<IConfigureOptions<HttpClientFactoryOptions>>(ServiceLifetime.Transient);
#endif
yield return new ExpectedRegistration<MyService>(ServiceLifetime.Transient);
}
}
Expand Down
4 changes: 2 additions & 2 deletions test/Correlate.Testing/Correlate.Testing.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net9.0;net8.0;net6.0;netstandard2.1</TargetFrameworks>
<TargetFrameworks>net9.0;net8.0;net6.0;net462</TargetFrameworks>
<TargetFrameworks Condition="'$(NetPreview)'=='true'">$(TargetFrameworks);netx.0</TargetFrameworks>
<IsTestProject>false</IsTestProject>
</PropertyGroup>
Expand All @@ -14,7 +14,7 @@
<Serilog_Extensions_Logging>3.1.0</Serilog_Extensions_Logging>
</PropertyGroup>

<PropertyGroup Condition="$(TargetFramework.StartsWith('netstandard2')) Or '$(TargetFramework)'=='netcoreapp3.1'">
<PropertyGroup Condition="$(TargetFramework.StartsWith('netstandard2')) Or '$(TargetFramework)'=='net462'">
<Serilog_Extensions_Logging>3.1.0</Serilog_Extensions_Logging>
</PropertyGroup>

Expand Down
1 change: 1 addition & 0 deletions test/Directory.Build.targets
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
<Using Include="FluentAssertions" />
<Using Include="NSubstitute" />
<Using Include="Xunit" />
<Using Include="System.Net.Http" />
</ItemGroup>

<ItemGroup>
Expand Down

0 comments on commit 306507a

Please sign in to comment.