Fixes #1324: change podman install method from a dev nightly to a homebrew binary #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ghtly to a homebrew binary
jiridanek
force-pushed
the
jd_fix_buildtype
branch
from
209fbdd to
fcc5c6e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1326 +/- ##
==========================================
+ Coverage 76.68% 76.73% +0.05%
==========================================
Files 246 246
Lines 63980 63980
Branches 5902 5902
==========================================
+ Hits 49060 49098 +38
+ Misses 12344 12315 -29
+ Partials 2576 2567 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ganeshmurthy
approved these changes
Dec 20, 2023
jiridanek
added a commit
to jiridanek/skupper-router
that referenced
this pull request
Jan 1, 2024
…ghtly to a homebrew binary (skupperproject#1326)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dev nightly is apparently buggy, which is causing the build issue. The homebrew version should be more stable.
Ubuntu 22.04 version is ancient (in the 3.x series) so that cannot be used. Building with podman inside another docker image (ubi9-init, for example) seems doable, but it complicates the GitHub Action a bit too much.
Ideally, I think that just using Docker to do the builds would be easiest. Let's consider that in the future.