Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove trace option #1290

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Conversation

pwright
Copy link
Member

@pwright pwright commented Nov 3, 2023

@ganeshmurthy does this make sense?

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #1290 (6350ae9) into main (110dbbd) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1290      +/-   ##
==========================================
- Coverage   78.43%   78.41%   -0.02%     
==========================================
  Files         246      246              
  Lines       63917    63916       -1     
  Branches     5902     5902              
==========================================
- Hits        50132    50119      -13     
- Misses      11122    11139      +17     
+ Partials     2663     2658       -5     
Flag Coverage Δ
pysystemtests 87.72% <ø> (ø)
pyunittests 54.60% <ø> (ø)
systemtests 72.40% <ø> (-0.03%) ⬇️
unittests 26.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
calculator 29.97% <ø> (ø)
systemtests 79.02% <ø> (-0.02%) ⬇️

Copy link
Contributor

@ganeshmurthy ganeshmurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I missed this. Looks good to me

@pwright pwright merged commit 20c09f7 into skupperproject:main Nov 3, 2023
35 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants