Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1267: Removed gdb, asan, tsan libraries and asan/tsan router … #1271

Merged

Conversation

ganeshmurthy
Copy link
Contributor

…executable from skupper-router container image

…/tsan router executable from skupper-router container image
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #1271 (19486d2) into main (f17aedb) will decrease coverage by 0.63%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1271      +/-   ##
==========================================
- Coverage   78.95%   78.32%   -0.63%     
==========================================
  Files         244      246       +2     
  Lines       63056    63557     +501     
  Branches     5931     5874      -57     
==========================================
- Hits        49784    49781       -3     
- Misses      10616    11119     +503     
- Partials     2656     2657       +1     
Flag Coverage Δ
pysystemtests 87.70% <ø> (ø)
pyunittests 54.60% <ø> (?)
systemtests 72.28% <ø> (-0.02%) ⬇️
unittests 26.52% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
calculator 30.06% <ø> (∅)
systemtests 78.94% <ø> (-0.02%) ⬇️

Copy link
Contributor

@jiridanek jiridanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also removes gdb, which maybe we want to keep around?

There is a follow-up change that needs to be made in skupper,

Overall, it looks good to me.

@ganeshmurthy ganeshmurthy merged commit d74d9d0 into skupperproject:main Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove gdb, asan, tsan libraries and asan/tsan router executable from skupper-router container image
2 participants