feat(alba): Handle inline associations #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introducing `InlineType` class for handling inline associations. This commit also adds `require "logger"` to avoid an error with console.
okuramasafumi
commented
Sep 20, 2024
| (base_classes + base_classes.flat_map(&:descendants)).uniq.sort_by(&:name) | ||
| .reject { |serializer| Typelizer.reject_class.call(serializer: serializer) } | ||
| (base_classes + base_classes.flat_map(&:descendants)).uniq | ||
| .reject { |serializer| Typelizer.reject_class.call(serializer: serializer) || serializer.name.nil? } |
There was a problem hiding this comment.
Adding a condition to check anonymous serializer.
| # InlineType is mainly used with Alba plugin to represent inline associations. | ||
| # `name `method` is the same interface as `Interface` class. | ||
| class InlineType | ||
| TEMPLATE = <<~ERB.strip |
There was a problem hiding this comment.
Heredoc is used as a template. This can be a separate file, but it is short enough.
| end | ||
|
|
||
| def name | ||
| properties = SerializerPlugins::Alba.new(serializer: @serializer, config: @config).properties |
There was a problem hiding this comment.
This is kind of dirty hack, but it's recursive so that inline associations can be deeply nested.
| @@ -54,6 +54,7 @@ def imports | |||
| .filter_map { |interface| interface.name if interface.name != name } | |||
|
|
|||
| custom_type_imports = attribute_types | |||
| .reject { |type| type.is_a?(InlineType) } | |||
There was a problem hiding this comment.
At the next line InlineType causes an error, so we need to reject it here.
|
@okuramasafumi thanks for your PR! I tried it and noticed that class FooSerializer
include Alba::Resource
helper Typelizer::DSL
many :bars do
typelize_from Bar
attributes :id, :name
end
endSo I tried to fix it in #8, would love to hear your thoughts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6
Abstract
This change introduces a new class
InlineTypefor handling inline associations of Alba.I'd like to know if this approach is good not not. If it's good, I'll add some tests for this case.
Details
There are two things to do:
I'll add some notes as a comment later.