Raise error when parameter attributes misses required keys

skryukov · Oct 23, 2023 · 7287a7d · 7287a7d
1 parent ae33d45
commit 7287a7d
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/lib/skooma/objects/parameter/keywords/value_parser.rb b/lib/skooma/objects/parameter/keywords/value_parser.rb
@@ -9,9 +9,11 @@ module Keywords
  module ValueParser
  class << self
  def call(instance, result)
- type = result.sibling(instance, "in").annotation
- key = result.sibling(instance, "name").annotation
- raise Error, "Missing key: #{key}" unless key
+ type = result.sibling(instance, "in")&.annotation
+ raise Error, "Missing `in` key #{result.path}" unless type
+
+ key = result.sibling(instance, "name")&.annotation
+ raise Error, "Missing `name` key #{instance.path}: #{key}" unless key
 
  case type
  when "query"
@@ -30,7 +32,7 @@ def call(instance, result)
  when "cookie"
  # instance["headers"]["Cookie"]
  else
- raise Error, "Unknown location: #{result.sibling(instance, "in").annotation}"
+ raise Error, "Unknown location: #{type}"
  end
  end