Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript support for the installation generator #11

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

skryukov
Copy link
Owner

@skryukov skryukov commented Aug 6, 2024

This PR adds TypeScript support for the installation generator. Note that it doesn't include scaffold generators yet.

@skryukov skryukov force-pushed the simplify-installation branch 3 times, most recently from bf5534e to 26da1da Compare August 10, 2024 06:15
Base automatically changed from simplify-installation to main August 10, 2024 06:16
@skryukov skryukov force-pushed the typescript-installation-script branch from 1d2756a to d64f569 Compare August 10, 2024 06:24
Copy link

netlify bot commented Aug 10, 2024

Deploy Preview for inertia-rails ready!

Name Link
🔨 Latest commit ac4bfca
🔍 Latest deploy log https://app.netlify.com/sites/inertia-rails/deploys/67066392f4e6a2000833eb33
😎 Deploy Preview https://deploy-preview-11--inertia-rails.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Shaglock
Copy link
Contributor

Shaglock commented Oct 5, 2024

Hello @skryukov what is needed to bring this PR to main? How can we help?

@skryukov skryukov force-pushed the typescript-installation-script branch 2 times, most recently from 1c8f3c2 to 4b2ce5c Compare October 9, 2024 10:52
@skryukov skryukov force-pushed the typescript-installation-script branch from 4b2ce5c to ac4bfca Compare October 9, 2024 11:05
@skryukov skryukov marked this pull request as ready for review October 9, 2024 11:08
@skryukov skryukov merged commit 7bcea93 into main Oct 9, 2024
9 checks passed
@skryukov skryukov deleted the typescript-installation-script branch October 9, 2024 11:09
@skryukov
Copy link
Owner Author

skryukov commented Oct 9, 2024

@Shaglock thanks for pinging. I've just released a new version with TypeScript support for the installation generator 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants