Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blogpost - Test-Frame introduction #15

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Blogpost - Test-Frame introduction #15

merged 4 commits into from
Mar 26, 2024

Conversation

im-konge
Copy link
Member

No description provided.

@im-konge im-konge self-assigned this Mar 22, 2024
@github-actions GitHub Actions
Copy link

Thanks for pull request!!!
hey @kornys @Frawless @obabec

see-quick
see-quick approved these changes Mar 24, 2024
View reviewed changes
Copy link

@see-quick see-quick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only a few nits worth of consideration... 👍 LGTM

posts/tools/test-frame-introduction.md Outdated Show resolved Hide resolved
posts/tools/test-frame-introduction.md Outdated Show resolved Hide resolved
posts/tools/test-frame-introduction.md Outdated Show resolved Hide resolved
posts/tools/test-frame-introduction.md Show resolved Hide resolved
posts/tools/test-frame-introduction.md Outdated Show resolved Hide resolved
posts/tools/test-frame-introduction.md Outdated Show resolved Hide resolved
posts/tools/test-frame-introduction.md Show resolved Hide resolved
obabec
obabec reviewed Mar 25, 2024
View reviewed changes
posts/tools/test-frame-introduction.md Outdated Show resolved Hide resolved
posts/tools/test-frame-introduction.md Outdated Show resolved Hide resolved
posts/tools/test-frame-introduction.md Outdated Show resolved Hide resolved
posts/tools/test-frame-introduction.md Outdated Show resolved Hide resolved
posts/tools/test-frame-introduction.md Outdated Show resolved Hide resolved
posts/tools/test-frame-introduction.md Outdated Show resolved Hide resolved
posts/tools/test-frame-introduction.md Outdated Show resolved Hide resolved
posts/tools/test-frame-introduction.md Outdated Show resolved Hide resolved
posts/tools/test-frame-introduction.md Outdated Show resolved Hide resolved
posts/tools/test-frame-introduction.md Outdated Show resolved Hide resolved
kornys
kornys approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@kornys kornys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after fixes :)

Frawless
Frawless reviewed Mar 25, 2024
View reviewed changes
posts/tools/test-frame-introduction.md Outdated Show resolved Hide resolved
posts/tools/test-frame-introduction.md Outdated Show resolved Hide resolved
novotnyJiri
novotnyJiri approved these changes Mar 25, 2024
View reviewed changes
Copy link

@novotnyJiri novotnyJiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have any other suggestion which my colleagues did not already suggest. Good work!

@im-konge
comments from all
b2ffea0 
Signed-off-by: Lukas Kral <[email protected]>
@im-konge
add note about contribution
39a3d3e 
Signed-off-by: Lukas Kral <[email protected]>
@im-konge im-konge merged commit db477e4 into main Mar 26, 2024
1 check passed
obabec pushed a commit that referenced this pull request Mar 26, 2024
@im-konge @obabec
Blogpost - Test-Frame introduction (#15)
f173b75 
* start with test-frame intro blogpost

Signed-off-by: Lukas Kral <[email protected]>

* finish the blogpost

Signed-off-by: Lukas Kral <[email protected]>

* comments from all

Signed-off-by: Lukas Kral <[email protected]>

* add note about contribution

Signed-off-by: Lukas Kral <[email protected]>

---------

Signed-off-by: Lukas Kral <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novotnyJiri novotnyJiri novotnyJiri approved these changes

@see-quick see-quick see-quick approved these changes

@obabec obabec obabec approved these changes

@kornys kornys kornys approved these changes

@Frawless Frawless Frawless approved these changes

Assignees

@im-konge im-konge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@im-konge @Frawless @kornys @obabec @see-quick @novotnyJiri