chore: eslint migration #2265
Draft
chore: eslint migration #2265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2024-12-22 06:23:33 CET |
eunnbi
commented
Dec 22, 2024
| "lint": "eslint . --ext .js,.ts,.tsx,.jsx", | ||
| "lint": "eslint .", |
There was a problem hiding this comment.
Comment on lines
+112
to
+122
| { | ||
| files: ['apps/backend/**/*.spec.ts'], | ||
| languageOptions: { | ||
| globals: { | ||
| ...globals.mocha | ||
| } | ||
| }, | ||
| rules: { | ||
| '@typescript-eslint/no-unused-expressions': 'off' | ||
| } | ||
| }, |
There was a problem hiding this comment.
eunnbi
commented
Dec 22, 2024
Comment on lines
-132
to
+133
| - name: Install dev dependencies | ||
| run: pnpm install --dev | ||
| - name: Install dependencies | ||
| run: pnpm install |
There was a problem hiding this comment.
AS-IS: Dev 의존성만 설치 -> eslint-config-next/parser.js에서 next/dist/compiled/babel/eslint-parser 의존성을 찾지 못함
TO-BE: 모든 의존성 설치
(더 나은 해결 방법 있으면 알려주세요..)
eunnbi
force-pushed
the
t490-eslint-migration
branch
from
cd11a0c to
0aaeece
Compare
eunnbi
force-pushed
the
t490-eslint-migration
branch
from
0aaeece to
53bf8df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context
Before submitting the PR, please make sure you do the following
fixes #123).